Fix/ios timepicker default date actually return the launch date#651
Open
guilhermeseckert wants to merge 1 commit intommazzarolo:masterfrom
Conversation
guilhermeseckert
force-pushed
the
fix/ios-timepicker-default-date-actually-return-the-launch-date
branch
from
ecdd5df to
6a4fe2d
Compare
mmazzarolo
reviewed
Jul 28, 2022
|
|
||
| static getDerivedStateFromProps(props, state) { | ||
| if (props.isVisible && !state.isPickerVisible) { | ||
| return { currentDate: props.date, isPickerVisible: true }; |
Owner
There was a problem hiding this comment.
Isn't this change breaking the case where users change the initial date prop?
mmazzarolo
requested changes
Sep 6, 2022
Owner
mmazzarolo
left a comment
mmazzarolo
left a comment
There was a problem hiding this comment.
Thanks for the PR! Unfortunately I this change breaks the case where users change the initial date prop.
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Issue: #578
When using the time picker using an interval (for example 30 minutes), whenever the user clicks "OK" without changing the date, it return the locally cached time.
Test Plan
Tested on an internal company project on iOS simulator and device. Both worked.