7. try

Author: MrMineDe

.github/workflows/docker.yml

@@ -52,61 +52,92 @@ jobs:
           docker compose -f docker/docker-compose.yml build --pull
 
       - name: Tag & push built images
-        # This step:
-        # 1. lists services from docker compose
-        # 2. obtains the built image ID for each service
-        # 3. tags each image as: $REGISTRY/$OWNER/<service>:<sha>
-        # 4. pushes the tag, and also pushes :latest when on main or when the ref is a tag
         run: |
           set -euo pipefail
 
           REGISTRY=${{ env.REGISTRY }}
           OWNER=${{ env.OWNER }}
           SHA=${{ env.COMMIT_SHORT }}
+          REPO_NAME=${{ github.event.repository.name }}
 
           echo "Registry: $REGISTRY"
           echo "Owner: $OWNER"
+          echo "Repo: $REPO_NAME"
           echo "Tag: $SHA"
 
-          # get list of services defined in compose
+          # list services defined in compose
           services=$(docker compose -f docker/docker-compose.yml config --services)
           if [ -z "$services" ]; then
             echo "No services found in docker-compose.yml"
             exit 1
           fi
 
           # decide whether to push 'latest' as well
-          ref="${GITHUB_REF:-}"
           push_latest=false
-          if [[ "${GITHUB_REF}" == "refs/heads/main" ]] || [[ "${GITHUB_REF}" == refs/tags/* ]]; then
+          if [[ "${GITHUB_REF:-}" == "refs/heads/main" ]] || [[ "${GITHUB_REF:-}" == refs/tags/* ]]; then
             push_latest=true
           fi
 
           for svc in $services; do
-            echo "Processing service: $svc"
+            echo "Checking service: $svc"
+
+            # Extract IMAGE and whether a build: exists for this service from 'docker compose config'
+            svc_info=$(docker compose -f docker/docker-compose.yml config | awk -v svc="$svc" '
+              $0 ~ "services:" { in_services=1 }
+              in_services && $0 ~ "^[[:space:]]*"svc":" { in_svc=1; next }
+              in_svc && $0 ~ "^[[:space:]]*[^[:space:]]" { exit }
+              in_svc {
+                if ($1 == "image:") { gsub(/"/,"",$2); print "IMAGE="$2 }
+                if ($1 == "build:") { print "HASBUILD=1" }
+              }
+            ')
+
+            # evaluate the small KEY=VAL output (safe in CI)
+            unset IMAGE HASBUILD
+            eval "$svc_info" || true
+
+            # only process services that have both build: and image:
+            if [ -z "${IMAGE:-}" ] || [ -z "${HASBUILD:-}" ]; then
+              echo "Skipping $svc (requires both build: and image:)."
+              continue
+            fi
+
+            echo "Service $svc has build and image -> $IMAGE"
 
-            # image id produced by compose build for this service
+            # determine source reference for tagging: prefer compose image id, then image:latest, then image (no tag)
+            src_ref=""
             imgid=$(docker compose -f docker/docker-compose.yml images -q "$svc" 2>/dev/null || true)
-            if [ -z "$imgid" ]; then
-              echo "Failed to get image id for service $svc"
+            if [ -n "$imgid" ]; then
+              src_ref="$imgid"
+            elif docker image inspect "$IMAGE:latest" >/dev/null 2>&1; then
+              src_ref="$IMAGE:latest"
+            elif docker image inspect "$IMAGE" >/dev/null 2>&1; then
+              src_ref="$IMAGE"
+            else
+              echo "No built image found for $svc (expected $IMAGE). Did the build step succeed?"
               exit 1
             fi
 
-            target="$REGISTRY/$OWNER/${{ github.event.repository.name }}-$svc:$SHA"
-            echo "Tagging $imgid -> $target"
-            docker tag "$imgid" "$target"
+            target="$REGISTRY/$OWNER/${REPO_NAME}-$svc:$SHA"
+            echo "Tagging $src_ref -> $target"
+            docker tag "$src_ref" "$target"
 
             echo "Pushing $target"
             docker push "$target"
 
             if [ "$push_latest" = true ]; then
-              latest_tag="$REGISTRY/$OWNER/${{ github.event.repository.name }}-$svc:latest"
+              latest_tag="$REGISTRY/$OWNER/${REPO_NAME}-$svc:latest"
               echo "Also tagging & pushing latest: $latest_tag"
-              docker tag "$imgid" "$latest_tag"
+              docker tag "$src_ref" "$latest_tag"
               docker push "$latest_tag"
             fi
+
+            # clean up variables for next iteration
+            unset IMAGE HASBUILD src_ref imgid
           done
 
+          echo "All done. Images pushed."
+
       - name: Output pushed images
         run: |
           echo "Images pushed for commit $COMMIT_SHORT"