Fix dotnet remove package project argument not recognized (dotnet#53401)

Author: martinrrm

src/Cli/Microsoft.DotNet.Cli.Definitions/Commands/Hidden/Remove/RemovePackageCommandDefinition.cs

@@ -1,11 +1,17 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System.CommandLine;
 using Microsoft.DotNet.Cli.Commands.Package.Remove;
 
 namespace Microsoft.DotNet.Cli.Commands.Hidden.Remove.Package;
 
 internal sealed class RemovePackageCommandDefinition() : PackageRemoveCommandDefinitionBase(Name)
 {
     public new const string Name = "package";
+
+    public RemoveCommandDefinition Parent => (RemoveCommandDefinition)Parents.Single();
+
+    public override Argument<string>? GetProjectOrFileArgument()
+        => Parent.ProjectOrFileArgument;
 }

src/Cli/Microsoft.DotNet.Cli.Definitions/Commands/Package/PackageRemoveCommandDefinition.cs

@@ -16,6 +16,9 @@ public PackageRemoveCommandDefinition()
         Options.Add(ProjectOption);
         Options.Add(FileOption);
     }
+
+    public override Argument<string>? GetProjectOrFileArgument()
+        => null;
 }
 
 internal abstract class PackageRemoveCommandDefinitionBase : Command
@@ -36,4 +39,6 @@ public PackageRemoveCommandDefinitionBase(string name)
         Arguments.Add(CmdPackageArgument);
         Options.Add(InteractiveOption);
     }
+
+    public abstract Argument<string>? GetProjectOrFileArgument();
 }

src/Cli/dotnet/Commands/Package/Remove/PackageRemoveCommand.cs

@@ -25,7 +25,11 @@ public override int Execute()
             throw new GracefulException(CliCommandStrings.PackageRemoveSpecifyExactlyOnePackageReference);
         }
 
-        var (fileOrDirectory, allowedAppKinds) = PackageCommandParser.ProcessPathOptions(_definition.FileOption, _definition.ProjectOption, projectOrFileArgument: null, _parseResult);
+        var (fileOrDirectory, allowedAppKinds) = PackageCommandParser.ProcessPathOptions(
+            _definition.FileOption,
+            _definition.ProjectOption,
+            _definition.GetProjectOrFileArgument(),
+            _parseResult);
 
         if (allowedAppKinds.HasFlag(AppKinds.FileBased) && VirtualProjectBuilder.IsValidEntryPointPath(fileOrDirectory))
         {

test/dotnet.Tests/CommandTests/Package/Remove/GivenDotnetRemovePackage.cs

@@ -86,6 +86,33 @@ public void WhenReferencedPackageIsPassedItGetsRemoved()
             remove.StdErr.Should().BeEmpty();
         }
 
+        [Fact]
+        public void WhenReferencedPackageIsRemovedUsingPositionalProjectArgumentItGetsRemoved()
+        {
+            const string testAsset = "TestAppSimple";
+            var projectDirectory = TestAssetsManager
+                .CopyTestAsset(testAsset)
+                .WithSource().Path;
+
+            var packageName = "Newtonsoft.Json";
+            var projectFilePath = Path.Combine(projectDirectory, $"{testAsset}.csproj");
+            var parentDirectory = Directory.GetParent(projectDirectory)!.FullName;
+            var relativeProjectPath = Path.GetRelativePath(parentDirectory, projectFilePath);
+
+            new DotnetCommand(Log)
+                .WithWorkingDirectory(projectDirectory)
+                .Execute("add", "package", packageName)
+                .Should().Pass();
+
+            var remove = new DotnetCommand(Log)
+                .WithWorkingDirectory(parentDirectory)
+                .Execute("remove", relativeProjectPath, "package", packageName);
+
+            remove.Should().Pass();
+            remove.StdOut.Should().Contain($"Removing PackageReference for package '{packageName}' from project '{relativeProjectPath}'.");
+            remove.StdErr.Should().BeEmpty();
+        }
+
         [Fact]
         public void FileBasedApp()
         {