Skip to content

ConfoundingSHAP#551

Open
mariebrockschmidt wants to merge 4 commits into
mmschlk:mainfrom
mariebrockschmidt:main
Open

ConfoundingSHAP#551
mariebrockschmidt wants to merge 4 commits into
mmschlk:mainfrom
mariebrockschmidt:main

Conversation

@mariebrockschmidt

Copy link
Copy Markdown

Motivation and Context

This PR adds the ConfoundingSHAP games defined in the paper:

Public API Changes

  • No Public API changes
  • Yes, Public API changes (Details below)

Adding the shapiq_games for further benchmarking.

How Has This Been Tested?

example file has been created and functionality was tested locally.

Checklist

  • The changes have been tested locally.
  • Documentation has been updated (if the public API or usage changes).
  • An entry has been added to CHANGELOG.md (if relevant for users).
  • The code follows the project's style guidelines.
  • I have considered the impact of these changes on the public API.

@Advueu963 Advueu963 self-requested a review June 16, 2026 11:45
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Advueu963 Advueu963 requested a review from mmschlk June 16, 2026 13:36
@mmschlk

mmschlk commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Very nice! One question I had is weather we should merge this PR after the refactor of the benchmark? Or what do you think @mariebrockschmidt and @Advueu963?

@Advueu963

Copy link
Copy Markdown
Collaborator

@mmschlk this would not really introduce many changes in shapiq-benchmark, only a few registrations in the dictionaries of shapiq-benchmark. But also happy to do so after the merge of shapiq-benchmark.

@mmschlk

mmschlk commented Jul 6, 2026

Copy link
Copy Markdown
Owner

@mariebrockschmidt and @Advueu963, now with 1.6.0 we have the rework of the shapiq-benchmark in. We could now put this one in as well? Are there any things we need to do now or is this already good to go? :)

@mmschlk mmschlk left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From me this is good. But @Advueu963 should still take a look. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants