Skip to content

Commit 05928e3

Browse files
fix: patch axios temporarily / bump version (#427)
bumping axios without this patch leads to type checking errors as seen here https://github.com/mnahkies/openapi-code-generator/actions/runs/22118781975/job/63933672790 ``` ... The types of 'config.transformRequest' are incompatible between these types. Type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index").AxiosRequestTransformer | import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index").AxiosRequestTransformer[]' is not assignable to type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index", { with: { "resolution-mode": "import" } }).AxiosRequestTransformer | import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/...'. Type 'AxiosRequestTransformer' is not assignable to type 'AxiosRequestTransformer | AxiosRequestTransformer[]'. Type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index").AxiosRequestTransformer' is not assignable to type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index", { with: { "resolution-mode": "import" } }).AxiosRequestTransformer'. The 'this' types of each signature are incompatible. Type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index", { with: { "resolution-mode": "import" } }).InternalAxiosRequestConfig<any>' is not assignable to type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index").InternalAxiosRequestConfig<any>' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties. Types of property 'transformRequest' are incompatible. Type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index", { with: { "resolution-mode": "import" } }).AxiosRequestTransformer | import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/...' is not assignable to type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index").AxiosRequestTransformer | import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index").AxiosRequestTransformer[]'. Type 'AxiosRequestTransformer' is not assignable to type 'AxiosRequestTransformer | AxiosRequestTransformer[]'. ``` The message is obtuse, but ultimately it's caused by axios/axios#5560 creating an incompatibility between the cjs and esm typings. Upstream fix submitted: axios/axios#7414 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 parent ee3a619 commit 05928e3

6 files changed

Lines changed: 49 additions & 29 deletions

File tree

e2e/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"@nahkies/typescript-express-runtime": "workspace:*",
2020
"@nahkies/typescript-fetch-runtime": "workspace:*",
2121
"@nahkies/typescript-koa-runtime": "workspace:*",
22-
"axios": "1.13.2",
22+
"axios": "1.13.5",
2323
"express": "^5.1.0",
2424
"koa": "^3.1.1",
2525
"zod": "^3.25.74"

integration-tests/typescript-axios/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
},
1212
"dependencies": {
1313
"@nahkies/typescript-axios-runtime": "workspace:*",
14-
"axios": "1.13.2",
14+
"axios": "1.13.5",
1515
"dotenv": "^17.2.3",
1616
"tslib": "^2.8.1"
1717
},

packages/typescript-axios-runtime/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@
3333
"tslib": "^2.8.1"
3434
},
3535
"peerDependencies": {
36-
"axios": "^1.6.8 <1.13.3"
36+
"axios": "^1.13.5 <1.13.6"
3737
},
3838
"devDependencies": {
3939
"@jest/globals": "^30.2.0",
40-
"axios": "1.13.2",
40+
"axios": "1.13.5",
4141
"jest": "^30.2.0",
4242
"typescript": "^5.9.3"
4343
},

patches/axios.patch

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
diff --git a/index.d.cts b/index.d.cts
2+
index 7a4eff949961ec02504ddf91f67874e567e1ee49..a32064ec7a0f3b09a021ad5fbfd0f3bd1c10033e 100644
3+
--- a/index.d.cts
4+
+++ b/index.d.cts
5+
@@ -417,7 +417,7 @@ declare namespace axios {
6+
httpAgent?: any;
7+
httpsAgent?: any;
8+
proxy?: AxiosProxyConfig | false;
9+
- cancelToken?: CancelToken;
10+
+ cancelToken?: CancelToken | undefined;
11+
decompress?: boolean;
12+
transitional?: TransitionalOptions;
13+
signal?: GenericAbortSignal;

pnpm-lock.yaml

Lines changed: 15 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pnpm-workspace.yaml

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,9 @@ packages:
33
- integration-tests/*
44
- e2e
55

6-
minimumReleaseAge: 10080 # 7 days in minutes
7-
8-
minimumReleaseAgeExclude:
9-
# Renovate security update: lodash@4.17.23
10-
- lodash@4.17.23
11-
- '@isaacs/brace-expansion@5.0.1'
12-
13-
nodeOptions: "${NODE_OPTIONS:- } --experimental-vm-modules"
14-
156
dedupeInjectedDeps: true
167

17-
linkWorkspacePackages: deep
8+
gitChecks: false
189

1910
ignoredBuiltDependencies:
2011
- '@parcel/watcher'
@@ -26,11 +17,25 @@ ignoredBuiltDependencies:
2617
- sharp
2718
- unrs-resolver
2819

20+
linkWorkspacePackages: deep
21+
22+
minimumReleaseAge: 10080
23+
24+
minimumReleaseAgeExclude:
25+
- lodash@4.17.23
26+
- '@isaacs/brace-expansion@5.0.1'
27+
- axios@1.13.5
28+
29+
nodeOptions: ${NODE_OPTIONS:- } --experimental-vm-modules
30+
2931
overrides:
30-
'@types/node': 22.16.5
31-
'zod@4.1.11': '4.1.13'
3232
'@isaacs/brace-expansion': 5.0.1
33+
'@types/node': 22.16.5
3334
tar: 7.5.7
35+
zod@4.1.11: 4.1.13
36+
37+
patchedDependencies:
38+
axios: patches/axios.patch
3439

3540
preferWorkspacePackages: true
3641

@@ -39,6 +44,3 @@ publicHoistPattern:
3944
- '@azure-tools/*'
4045
- '@types/node'
4146
- '@biomejs/biome'
42-
43-
# GH actions doesn't checkout the branch
44-
gitChecks: false

0 commit comments

Comments
 (0)