fix: drop broken readOnly support

Author: mnahkies

packages/documentation/src/app/overview/compatibility/page.mdx

@@ -29,7 +29,7 @@ Most common functionality used by JSON based APIs should work.
 - Decent support for `paths` using `application/x-www-form-urlencoded` request bodies
 - Comprehensive support for most `schema` properties, including json validation stuff like `minLength`,
 but only for `json` content types. Notable exceptions:
-- `readonly` is currently implemented incorrectly
+- `writeOnly` / `readonly` is ignored
 - `discriminator` is ignored, but `union` / `intersection` types will be generated based on `anyOf` / `allOf` so
 this isn't an issue in practice
 - No support for security schemes, you'll need to fudge these as header parameters, or implement out-of-band
@@ -242,8 +242,7 @@ CLI option.
 The majority of attributes that can be specified by `schema` objects are supported, and accurately match the underlying
 openapi specification / json schema validation specifications.
 
-Most notable exception is `readOnly` / `writeOnly` which are currently implemented incorrectly, planned to be addressed
-as a breaking change prior to v1.
+Most notable exception is `readOnly` / `writeOnly` which are currently ignored, planned to be addressed prior to v1.
 
 | Attribute            | Supported | Notes                                                                                                                                                    |
 |:---------------------|:---------:|:---------------------------------------------------------------------------------------------------------------------------------------------------------|
@@ -275,7 +274,7 @@ as a breaking change prior to v1.
 | default              |     ✅     |                                                                                                                                                          |
 | nullable             |     ✅     | Also supports `type: null` as an alternative                                                                                                             |
 | discriminator        |    🚫     | Ignored. Union / Intersection types are usd based on `anyOf` / `allOf` / `oneOf`.                                                                        |
-| readOnly             |    🚫     | Produces `readonly` modifiers, but this behavior [is incorrect](https://github.com/mnahkies/openapi-code-generator/issues/157)                           |
+| readOnly             |    🚫     | Not yet supported                                                                                                                                        |
 | writeOnly            |    🚫     | Not yet supported                                                                                                                                        |
 | example              |  __N/A__  | Ignored                                                                                                                                                  |
 | externalDocs         |  __N/A__  | Ignored                                                                                                                                                  |

packages/openapi-code-generator/src/core/input.spec.ts

@@ -19,23 +19,20 @@ describe("core/input - SchemaNormalizer", () => {
       type: "any",
       default: undefined,
       nullable: false,
-      readOnly: false,
       "x-internal-preprocess": undefined,
     } satisfies IRModelAny,
     never: {
       isIRModel: true,
       type: "never",
       default: undefined,
       nullable: false,
-      readOnly: false,
       "x-internal-preprocess": undefined,
     } satisfies IRModelNever,
     object: {
       isIRModel: true,
       type: "object",
       default: undefined,
       nullable: false,
-      readOnly: false,
       properties: {},
       required: [],
       allOf: [],
@@ -49,7 +46,6 @@ describe("core/input - SchemaNormalizer", () => {
       type: "array",
       default: undefined,
       nullable: false,
-      readOnly: false,
       uniqueItems: false,
       minItems: undefined,
       maxItems: undefined,
@@ -65,7 +61,6 @@ describe("core/input - SchemaNormalizer", () => {
       minLength: undefined,
       nullable: false,
       pattern: undefined,
-      readOnly: false,
       "x-enum-extensibility": undefined,
       "x-internal-preprocess": undefined,
     } satisfies IRModelString,
@@ -81,7 +76,6 @@ describe("core/input - SchemaNormalizer", () => {
       inclusiveMinimum: undefined,
       multipleOf: undefined,
       nullable: false,
-      readOnly: false,
       "x-enum-extensibility": undefined,
       "x-internal-preprocess": undefined,
     } satisfies IRModelNumeric,
@@ -91,7 +85,6 @@ describe("core/input - SchemaNormalizer", () => {
       default: undefined,
       enum: undefined,
       nullable: false,
-      readOnly: false,
       "x-internal-preprocess": undefined,
     } satisfies IRModelBoolean,
   }
@@ -104,7 +97,6 @@ describe("core/input - SchemaNormalizer", () => {
       value: base.any,
       default: undefined,
       nullable: false,
-      readOnly: false,
       "x-internal-preprocess": undefined,
     } satisfies IRModelRecord,
   }

packages/openapi-code-generator/src/core/input.ts

@@ -753,7 +753,6 @@ export class SchemaNormalizer {
     const base: IRModelBase = {
       isIRModel: true,
       nullable: schemaObject.nullable || false,
-      readOnly: schemaObject.readOnly || false,
       default: schemaObject.default,
       "x-internal-preprocess": schemaObject["x-internal-preprocess"],
     }

packages/openapi-code-generator/src/core/openapi-types-normalized.ts

@@ -10,7 +10,8 @@ export interface IRModelBase {
   isIRModel: true
   // Note: meaningless for top level objects, maybe we can exclude these somehow in that case
   nullable: boolean /* false */
-  readOnly: boolean /* false */
+  // todo: bring back but support properly
+  // readOnly: boolean /* false */
   default?: unknown | undefined
   "x-internal-preprocess"?: MaybeIRPreprocess | undefined
 }

packages/openapi-code-generator/src/typescript/common/type-builder.ts

@@ -212,8 +212,6 @@ export class TypeBuilder implements ICompilable {
               const isRequired = schemaObject.required.some((it) => it === name)
               const type = this.schemaObjectToType(definition)
 
-              const isReadonly = isRef(definition) ? false : definition.readOnly
-
               // ensure compatibility with `exactOptionalPropertyTypes` compiler option
               // https://www.typescriptlang.org/tsconfig#exactOptionalPropertyTypes
               const exactOptionalPropertyTypes =
@@ -224,7 +222,7 @@ export class TypeBuilder implements ICompilable {
                 type: exactOptionalPropertyTypes
                   ? union(type, "undefined")
                   : type,
-                isReadonly,
+                isReadonly: false,
                 isRequired,
               })
             })

packages/openapi-code-generator/src/typescript/common/typescript-common.ts

@@ -284,7 +284,6 @@ export function requestBodyAsParameter(
         isIRModel: true,
         type: "never",
         nullable: false,
-        readOnly: false,
       },
       deprecated: false,
     },

packages/openapi-code-generator/src/typescript/server/server-operation-builder.ts

@@ -289,7 +289,6 @@ export class ServerOperationBuilder {
               schema.properties[key] ?? {
                 isIRModel: true,
                 nullable: false,
-                readOnly: false,
                 type: "any",
               },
             ),