fix: skip request bodies with empty schemas

Author: mnahkies

packages/openapi-code-generator/src/typescript/client/client-operation-builder.ts

@@ -1,4 +1,5 @@
 import {generationLib} from "../../core/generation-lib"
+import {logger} from "../../core/logger"
 import type {
   IROperation,
   IRParameter,
@@ -99,7 +100,17 @@ export class ClientOperationBuilder {
     requestBodyParameter?: IRParameter
     requestBodyContentType?: string
   } {
-    return requestBodyAsParameter(this.operation)
+    const result = requestBodyAsParameter(this.operation)
+    const schema = result.requestBodyParameter?.schema
+
+    if (schema && this.models.isEmptyObject(schema)) {
+      logger.warn(
+        `[${this.route}]: skipping requestBody parameter that resolves to EmptyObject`,
+      )
+      return {}
+    }
+
+    return result
   }
 
   queryString(): string {

packages/openapi-code-generator/src/typescript/common/type-builder.ts

@@ -233,11 +233,9 @@ export class TypeBuilder implements ICompilable {
             ? `[key: string]: ${union(additionalPropertiesType, "undefined")}`
             : ""
 
-          const emptyObject =
-            schemaObject.additionalProperties === false &&
-            properties.length === 0
-              ? this.addStaticType("EmptyObject")
-              : ""
+          const emptyObject = this.isEmptyObject(schemaObject)
+            ? this.addStaticType("EmptyObject")
+            : ""
 
           properties.push(additionalProperties)
 
@@ -263,4 +261,17 @@ export class TypeBuilder implements ICompilable {
   toCompilationUnit(): CompilationUnit {
     return new CompilationUnit(this.filename, this.imports, this.toString())
   }
+
+  isEmptyObject(schemaObject: MaybeIRModel) {
+    const dereferenced = this.input.schema(schemaObject)
+
+    return (
+      dereferenced.type === "object" &&
+      dereferenced.allOf.length === 0 &&
+      dereferenced.anyOf.length === 0 &&
+      dereferenced.oneOf.length === 0 &&
+      dereferenced.additionalProperties === false &&
+      Object.keys(dereferenced.properties).length === 0
+    )
+  }
 }

packages/openapi-code-generator/src/typescript/server/server-operation-builder.ts

@@ -1,4 +1,5 @@
 import type {Input} from "../../core/input"
+import {logger} from "../../core/logger"
 import type {
   IRModelObject,
   IROperation,
@@ -265,14 +266,27 @@ export class ServerOperationBuilder {
 
   private requestBodyParameter(schemaSymbolName: string): Parameters["body"] {
     const {requestBodyParameter} = requestBodyAsParameter(this.operation)
+
     const isRequired = Boolean(requestBodyParameter?.required)
+
     const schema = requestBodyParameter
       ? this.schemaBuilder.fromModel(
           requestBodyParameter.schema,
           requestBodyParameter.required,
           true,
         )
       : undefined
+
+    if (
+      requestBodyParameter &&
+      this.types.isEmptyObject(requestBodyParameter.schema)
+    ) {
+      logger.warn(
+        `[${this.route}]: skipping requestBody parameter that resolves to EmptyObject`,
+      )
+      return {type: "void", schema: undefined, isRequired: false}
+    }
+
     let type = "void"
 
     if (schema && requestBodyParameter) {