chore: upgrade biome to v2 (#347)

- updates to latest version
- migrates config
- solves lint warnings / errors
- adjusts for the breaking changes

Author: mnahkies

biome.json

@@ -1,21 +1,22 @@
 {
-  "$schema": "https://biomejs.dev/schemas/1.5.3/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.1.2/schema.json",
   "vcs": {
     "enabled": true,
     "clientKind": "git",
     "useIgnoreFile": true
   },
-  "organizeImports": {
-    "enabled": true
-  },
+  "assist": { "actions": { "source": { "organizeImports": "on" } } },
   "files": {
-    "ignore": [
-      "integration-tests/**/generated/*",
-      "integration-tests-definitions/**/*",
-      "e2e/src/generated/**/*",
-      "schemas/*.json",
-      "**/package.json",
-      "package.json"
+    "includes": [
+      "**",
+      "!**/packages/openapi-code-generator/src/core/schemas/openapi-3.0-specification-validator.js",
+      "!**/packages/openapi-code-generator/src/core/schemas/openapi-3.1-specification-validator.js",
+      "!**/integration-tests/**/generated/**/*",
+      "!**/integration-tests-definitions/**/*",
+      "!**/e2e/src/generated/**/*",
+      "!**/schemas/**/*.json",
+      "!**/package.json",
+      "!**/package.json"
     ]
   },
   "formatter": {
@@ -35,18 +36,32 @@
   },
   "linter": {
     "enabled": true,
+    "domains": {
+      "project": "recommended",
+      "test": "recommended"
+    },
     "rules": {
-      "recommended": true
+      "recommended": true,
+      "complexity": {
+        "noForEach": "error"
+      },
+      "nursery": {
+        "noImportCycles": "error"
+      },
+      "style": {
+        "noParameterAssign": "error"
+      }
     },
-    "ignore": [
-      "packages/openapi-code-generator/src/core/schemas/openapi-3.0-specification-validator.js",
-      "packages/openapi-code-generator/src/core/schemas/openapi-3.1-specification-validator.js",
-      "integration-tests/**/generated/*",
-      "integration-tests-definitions/**/*",
-      "e2e/src/generated/**/*",
-      "schemas/*.json",
-      "**/package.json",
-      "package.json"
+    "includes": [
+      "**",
+      "!**/packages/openapi-code-generator/src/core/schemas/openapi-3.0-specification-validator.js",
+      "!**/packages/openapi-code-generator/src/core/schemas/openapi-3.1-specification-validator.js",
+      "!**/integration-tests/**/generated/**/*",
+      "!**/integration-tests-definitions/**/*",
+      "!**/e2e/src/generated/**/*",
+      "!**/schemas/**/*.json",
+      "!**/package.json",
+      "!**/package.json"
     ]
   }
 }

e2e/src/express.entrypoint.ts

@@ -28,12 +28,12 @@ export async function startExpressServer() {
       origin: "http://example.com",
     },
     router: createRouter(),
-    notFoundHandler: (req: Request, res: Response, next: NextFunction) => {
+    notFoundHandler: (_req: Request, res: Response, _next: NextFunction) => {
       res.status(404).json({code: 404, message: "route not found"})
     },
     errorHandler: (
       err: Error,
-      req: Request,
+      _req: Request,
       res: Response,
       next: NextFunction,
     ) => {

e2e/src/index.fetch.spec.ts

@@ -1,6 +1,5 @@
 import type {Server} from "node:http"
 import {beforeAll, describe, expect, it} from "@jest/globals"
-import type {AxiosError} from "axios"
 import {ApiClient, E2ETestClientServers} from "./generated/client/fetch/client"
 import {startServerFunctions} from "./index"
 import {numberBetween} from "./test-utils"

e2e/src/routes/express/escape-hatches.ts

@@ -1,13 +1,13 @@
 import {SkipResponse} from "@nahkies/typescript-express-runtime/server"
 import {
-  type GetEscapeHatchesPlainText,
   createRouter,
+  type GetEscapeHatchesPlainText,
 } from "../../generated/server/express/routes/escape-hatches"
 
 const getEscapeHatchesPlainText: GetEscapeHatchesPlainText = async (
   _,
-  respond,
-  req,
+  _respond,
+  _req,
   res,
 ) => {
   res.setHeader("x-ratelimit-remaining", "100")

e2e/src/routes/express/request-headers.ts

@@ -1,7 +1,7 @@
 import {
+  createRouter,
   type GetHeadersRequest,
   type GetHeadersUndeclared,
-  createRouter,
 } from "../../generated/server/express/routes/request-headers"
 
 const getHeadersUndeclared: GetHeadersUndeclared = async (

e2e/src/routes/express/validation.ts

@@ -1,10 +1,9 @@
-import type {ExpressRuntimeResponse} from "@nahkies/typescript-express-runtime/server"
 import {
+  createRouter,
   type GetResponses500,
   type GetResponsesEmpty,
   type GetValidationNumbersRandomNumber,
   type PostValidationEnums,
-  createRouter,
 } from "../../generated/server/express/routes/validation"
 
 const postValidationEnums: PostValidationEnums = async ({body}, respond) => {

e2e/src/routes/koa/escape-hatches.ts

@@ -1,12 +1,12 @@
 import {SkipResponse} from "@nahkies/typescript-koa-runtime/server"
 import {
-  type GetEscapeHatchesPlainText,
   createRouter,
+  type GetEscapeHatchesPlainText,
 } from "../../generated/server/koa/routes/escape-hatches"
 
 const getEscapeHatchesPlainText: GetEscapeHatchesPlainText = async (
   _,
-  respond,
+  _respond,
   ctx,
 ) => {
   ctx.set("x-ratelimit-remaining", "100")

e2e/src/routes/koa/request-headers.ts

@@ -1,7 +1,7 @@
 import {
+  createRouter,
   type GetHeadersRequest,
   type GetHeadersUndeclared,
-  createRouter,
 } from "../../generated/server/koa/routes/request-headers"
 
 const getHeadersUndeclared: GetHeadersUndeclared = async (

e2e/src/routes/koa/validation.ts

@@ -1,9 +1,9 @@
 import {
+  createRouter,
   type GetResponses500,
   type GetResponsesEmpty,
   type GetValidationNumbersRandomNumber,
   type PostValidationEnums,
-  createRouter,
 } from "../../generated/server/koa/routes/validation"
 
 const postValidationEnums: PostValidationEnums = async ({body}, respond) => {