Skip to content

Commit d978d37

Browse files
committed
fix: reduce diff
1 parent 8e4a7cd commit d978d37

5 files changed

Lines changed: 32 additions & 26 deletions

File tree

packages/openapi-code-generator/src/core/input.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import type {
2323
IRModelObject,
2424
IRModelString,
2525
IROperation,
26-
IROperationParams,
26+
IROperationParameters,
2727
IRParameter,
2828
IRParameterBase,
2929
IRParameterCookie,
@@ -174,7 +174,7 @@ export class Input {
174174
servers: this.normalizeServers(
175175
coalesce(definition.servers, paths.servers, []),
176176
),
177-
params: this.parameterNormalizer.normalizeParameters(
177+
parameters: this.parameterNormalizer.normalizeParameters(
178178
operationId,
179179
parameters,
180180
),
@@ -458,7 +458,7 @@ export class ParameterNormalizer {
458458
public normalizeParameters(
459459
operationId: string,
460460
parameters: (Parameter | Reference)[] = [],
461-
): IROperationParams {
461+
): IROperationParameters {
462462
const allParameters = parameters.map((it) => this.loader.parameter(it))
463463

464464
const pathParameters = allParameters.filter((it) => it.in === "path")

packages/openapi-code-generator/src/core/openapi-types-normalized.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ export type IRParameter =
175175
* $ref - location of the schema encapsulating params into an object
176176
* list - list of the parameters
177177
*/
178-
export interface IROperationParams {
178+
export interface IROperationParameters {
179179
all: IRParameter[]
180180
path: {name: string; list: IRParameterPath[]; $ref: Reference | undefined}
181181
query: {name: string; list: IRParameterQuery[]; $ref: Reference | undefined}
@@ -188,7 +188,7 @@ export interface IROperation {
188188
route: string
189189
method: HttpMethod
190190

191-
params: IROperationParams
191+
parameters: IROperationParameters
192192

193193
tags: string[]
194194
requestBody: IRRequestBody | undefined

packages/openapi-code-generator/src/typescript/client/client-operation-builder.ts

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export class ClientOperationBuilder {
6262
}
6363

6464
routeToTemplateString(paramName = "p"): string {
65-
const {route, params} = this.operation
65+
const {route, parameters} = this.operation
6666
const placeholders = extractPlaceholders(route)
6767

6868
return placeholders.reduce((result, {placeholder, wholeString}) => {
@@ -72,7 +72,9 @@ export class ClientOperationBuilder {
7272
)
7373
}
7474

75-
const parameter = params.path.list.find((it) => it.name === placeholder)
75+
const parameter = parameters.path.list.find(
76+
(it) => it.name === placeholder,
77+
)
7678

7779
if (!parameter) {
7880
throw new Error(
@@ -89,15 +91,17 @@ export class ClientOperationBuilder {
8991
}
9092

9193
methodParameter(): MethodParameterDefinition | undefined {
92-
const {params} = this.operation
94+
const {parameters} = this.operation
9395
const requestBody = this.requestBodyAsParameter()
9496

9597
return combineParams(
96-
[...params.all, requestBody?.parameter].filter(isDefined).map((it) => ({
97-
name: `${camelCase(it.name)}`,
98-
type: this.models.schemaObjectToType(it.schema),
99-
required: it.required,
100-
})),
98+
[...parameters.all, requestBody?.parameter]
99+
.filter(isDefined)
100+
.map((it) => ({
101+
name: `${camelCase(it.name)}`,
102+
type: this.models.schemaObjectToType(it.schema),
103+
required: it.required,
104+
})),
101105
)
102106
}
103107

@@ -131,7 +135,7 @@ export class ClientOperationBuilder {
131135

132136
queryString(): string {
133137
// todo: consider style / explode / allowReserved etc here
134-
return this.operation.params.query.list
138+
return this.operation.parameters.query.list
135139
.map((it) => `'${it.name}': ${this.paramName(it.name)}`)
136140
.join(",\n")
137141
}
@@ -141,7 +145,7 @@ export class ClientOperationBuilder {
141145
}: {
142146
nullContentTypeValue: "undefined" | "false"
143147
}): string {
144-
const paramHeaders = this.operation.params.header.list.map(
148+
const paramHeaders = this.operation.parameters.header.list.map(
145149
(it) => `'${it.name}': ${this.paramName(it.name)}`,
146150
)
147151

@@ -168,7 +172,7 @@ export class ClientOperationBuilder {
168172
}
169173

170174
hasHeader(name: string): boolean {
171-
const parameter = this.operation.params.header.list.find(
175+
const parameter = this.operation.parameters.header.list.find(
172176
(it) => it.name.toLowerCase() === name.toLowerCase(),
173177
)
174178

packages/openapi-code-generator/src/typescript/server/server-operation-builder.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export class ServerOperationBuilder {
7373
}
7474

7575
get route(): string {
76-
const {route, params} = this.operation
76+
const {route, parameters} = this.operation
7777

7878
const placeholders = extractPlaceholders(route)
7979

@@ -84,7 +84,9 @@ export class ServerOperationBuilder {
8484
)
8585
}
8686

87-
const parameter = params.path.list.find((it) => it.name === placeholder)
87+
const parameter = parameters.path.list.find(
88+
(it) => it.name === placeholder,
89+
)
8890

8991
if (!parameter) {
9092
throw new Error(
@@ -161,7 +163,7 @@ export class ServerOperationBuilder {
161163
}
162164

163165
private pathParameters(): Parameters["path"] {
164-
const $ref = this.operation.params.path.$ref
166+
const $ref = this.operation.parameters.path.$ref
165167

166168
const schema = $ref
167169
? this.schemaBuilder.fromModel(this.input.schema($ref), true, true)
@@ -173,11 +175,11 @@ export class ServerOperationBuilder {
173175
type = this.types.schemaObjectToType($ref)
174176
}
175177

176-
return {name: this.operation.params.path.name, schema: schema, type}
178+
return {name: this.operation.parameters.path.name, schema: schema, type}
177179
}
178180

179181
private queryParameters(): Parameters["query"] {
180-
const $ref = this.operation.params.query.$ref
182+
const $ref = this.operation.parameters.query.$ref
181183

182184
const schema = $ref
183185
? this.schemaBuilder.fromModel(this.input.schema($ref), true, true)
@@ -189,11 +191,11 @@ export class ServerOperationBuilder {
189191
type = this.types.schemaObjectToType($ref)
190192
}
191193

192-
return {name: this.operation.params.query.name, schema: schema, type}
194+
return {name: this.operation.parameters.query.name, schema: schema, type}
193195
}
194196

195197
private headerParameters(): Parameters["header"] {
196-
const $ref = this.operation.params.header.$ref
198+
const $ref = this.operation.parameters.header.$ref
197199

198200
const schema = $ref
199201
? this.schemaBuilder.fromModel(this.input.schema($ref), true, true)
@@ -205,7 +207,7 @@ export class ServerOperationBuilder {
205207
type = this.types.schemaObjectToType($ref)
206208
}
207209

208-
return {name: this.operation.params.header.name, schema: schema, type}
210+
return {name: this.operation.parameters.header.name, schema: schema, type}
209211
}
210212

211213
private requestBodyParameter(): Parameters["body"] {

packages/openapi-code-generator/src/typescript/server/typescript-koa/typescript-koa-router-builder.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ describe("typescript/server/typescript-koa/koa-router-builder", () => {
8383

8484
serverRouterBuilder.add({
8585
method: "GET",
86-
params: {
86+
parameters: {
8787
all: [],
8888
path: {list: [], name: "", $ref: undefined},
8989
query: {list: [], name: "", $ref: undefined},
@@ -101,7 +101,7 @@ describe("typescript/server/typescript-koa/koa-router-builder", () => {
101101
})
102102
serverRouterBuilder.add({
103103
method: "GET",
104-
params: {
104+
parameters: {
105105
all: [],
106106
path: {list: [], name: "", $ref: undefined},
107107
query: {list: [], name: "", $ref: undefined},

0 commit comments

Comments
 (0)