Skip to content

Commit 4b51621

Browse files
committed
FIX: Simplify
1 parent 10b4604 commit 4b51621

2 files changed

Lines changed: 34 additions & 36 deletions

File tree

tools/github_actions_dependencies.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/bin/bash -ef
22

3-
set -o pipefail
3+
set -eo pipefail
44

55
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
66
STD_ARGS="--progress-bar off --upgrade"
@@ -25,7 +25,7 @@ elif [[ "${MNE_CI_KIND}" == "pip" ]]; then
2525
else
2626
test "${MNE_CI_KIND}" == "pip-pre"
2727
STD_ARGS="$STD_ARGS --pre"
28-
${SCRIPT_DIR}/install_pre_requirements.sh
28+
${SCRIPT_DIR}/install_pre_requirements.sh || exit 1
2929
INSTALL_KIND="test_extra"
3030
fi
3131
echo ""

tools/install_pre_requirements.sh

Lines changed: 32 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,20 @@ QT_BINDING="PySide6"
1212
# Dependencies of scientific-python-nightly-wheels are installed here so that
1313
# we can use strict --index-url (instead of --extra-index-url) below
1414
set -x
15+
echo "::group::Prerequisites"
1516
python -m pip install $STD_ARGS pip setuptools packaging \
1617
threadpoolctl cycler fonttools kiwisolver pyparsing pillow python-dateutil \
1718
patsy pytz tzdata nibabel tqdm trx-python joblib numexpr \
1819
"$QT_BINDING!=6.9.1" \
1920
py-cpuinfo blosc2 hatchling "formulaic>=1.1.0"
2021
python -m pip uninstall -yq numpy
22+
echo "::endgroup::"
23+
echo "::group::Scientific Python Nightly Wheels"
2124
python -m pip install $STD_ARGS --only-binary ":all:" --default-timeout=60 \
2225
--index-url "https://pypi.anaconda.org/scientific-python-nightly-wheels/simple" \
23-
"numpy>=2.1.0.dev0" "scikit-learn>=1.6.dev0" "scipy>=1.15.0.dev0" \
26+
"numpy>=2.1.0.dev0" \
27+
"scipy>=1.15.0.dev0" \
28+
"scikit-learn>=1.6.dev0" \
2429
"matplotlib>=3.11.0.dev0" \
2530
"pandas>=3.0.0.dev0" \
2631
"dipy>=1.10.0.dev0" \
@@ -29,44 +34,37 @@ python -m pip install $STD_ARGS --only-binary ":all:" --default-timeout=60 \
2934
"h5py>=3.13.0"
3035
# TODO: should have above: "statsmodels>=0.15.0.dev0"
3136
# https://github.com/statsmodels/statsmodels/issues/9572
37+
echo "::endgroup::"
3238

3339
# No Numba because it forces an old NumPy version
3440

35-
pip install https://gitlab.com/obob/pymatreader/-/archive/master/pymatreader-master.zip
36-
37-
python -m pip install $STD_ARGS --only-binary ":all:" --extra-index-url "https://test.pypi.org/simple" "openmeeg>=2.6.0.dev4"
38-
39-
python -m pip install $STD_ARGS "git+https://github.com/nilearn/nilearn"
40-
41+
echo "::group::VTK"
4142
python -m pip install $STD_ARGS --only-binary ":all:" --extra-index-url "https://wheels.vtk.org" vtk
4243
python -c "import vtk"
43-
44-
python -m pip install $STD_ARGS "git+https://github.com/pyvista/pyvista" trame trame-vtk trame-vuetify jupyter ipyevents ipympl
45-
46-
python -m pip install $STD_ARGS git+https://github.com/pierreablin/picard
47-
48-
pip install $STD_ARGS git+https://github.com/pyvista/pyvistaqt
49-
50-
pip install $STD_ARGS imageio-ffmpeg xlrd mffpy traitlets pybv eeglabio defusedxml antio
51-
52-
pip install $STD_ARGS git+https://github.com/mne-tools/mne-qt-browser
53-
54-
pip install $STD_ARGS git+https://github.com/mne-tools/mne-bids
55-
56-
pip install $STD_ARGS git+https://github.com/nipy/nibabel
57-
58-
pip install $STD_ARGS git+https://github.com/joblib/joblib
59-
60-
# Disable protection for Azure, see
61-
# https://github.com/mne-tools/mne-python/pull/12609#issuecomment-2115639369
62-
GIT_CLONE_PROTECTION_ACTIVE=false pip install $STD_ARGS git+https://github.com/the-siesta-group/edfio
63-
64-
pip install $STD_ARGS git+https://github.com/h5io/h5io
65-
66-
pip install $STD_ARGS git+https://github.com/BUNPC/pysnirf2
67-
68-
# Make sure we're on a NumPy 2.0 variant
44+
echo "::endgroup::"
45+
46+
echo "::group::Everything else"
47+
python -m pip install $STD_ARGS \
48+
"git+https://github.com/pyvista/pyvista" \
49+
"git+https://github.com/pyvista/pyvistaqt" \
50+
"git+https://github.com/nilearn/nilearn" \
51+
"git+https://github.com/pierreablin/picard" \
52+
https://gitlab.com/obob/pymatreader/-/archive/master/pymatreader-master.zip \
53+
git+https://github.com/mne-tools/mne-qt-browser \
54+
git+https://github.com/mne-tools/mne-bids \
55+
git+https://github.com/nipy/nibabel \
56+
git+https://github.com/joblib/joblib \
57+
git+https://github.com/h5io/h5io \
58+
git+https://github.com/BUNPC/pysnirf2 \
59+
git+https://github.com/the-siesta-group/edfio \
60+
trame trame-vtk trame-vuetify jupyter ipyevents ipympl openmeeg \
61+
imageio-ffmpeg xlrd mffpy traitlets pybv eeglabio defusedxml antio
62+
echo "::endgroup::"
63+
64+
echo "::group::Make sure we're on a NumPy 2.0 variant"
6965
python -c "import numpy as np; assert np.__version__[0] == '2', np.__version__"
66+
echo "::endgroup::"
7067

71-
# And that Qt works
68+
echo "::group::Check Qt import"
7269
${SCRIPT_DIR}/check_qt_import.sh "$QT_BINDING"
70+
echo "::endgroup::"

0 commit comments

Comments
 (0)