Skip to content

Commit add35b7

Browse files
committed
FIX: More
1 parent 77fde19 commit add35b7

5 files changed

Lines changed: 11 additions & 8 deletions

File tree

.github/workflows/tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ jobs:
128128
if: matrix.kind == 'old'
129129
- run: bash ./tools/github_actions_verify_python.sh "${{ matrix.python }}"
130130
- run: bash ./tools/github_actions_dependencies.sh
131+
timeout-minutes: 5
131132
- run: python ./tools/github_actions_check_old_env.py
132133
if: matrix.kind == 'old'
133134
# Minimal commands on Linux (macOS stalls)

tools/get_minimal_commands.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,4 +79,3 @@ which mne_surf2bem
7979
mne_surf2bem --version
8080
which mri_average
8181
mri_average --version
82-
set +x

tools/github_actions_dependencies.sh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ if [ ! -z "$CONDA_ENV" ]; then
1212
conda remove -c conda-forge --force -y mne-base
1313
echo "::endgroup::"
1414
# If not on windows, do a non-editable install
15-
if [[ "${RUNNER_OS}" != "Windows" ]]; then
15+
if [[ "${CI_OS_NAME}" != "windows"* ]]; then
1616
INSTALL_ARGS=""
1717
fi
1818
GROUP="test_extra"
@@ -22,7 +22,7 @@ elif [[ "${MNE_CI_KIND}" == "minimal" ]]; then
2222
EXTRAS=""
2323
STD_ARGS="--progress-bar off ${MNE_QT_BACKEND}"
2424
echo "::group::Upgrading pip installation"
25-
python -m pip install --upgrade pip # upgrade pip to support --group
25+
python -m pip install --upgrade pip setuptools
2626
echo "::endgroup::"
2727
elif [[ "${MNE_CI_KIND}" == "old" ]]; then
2828
GROUP="" # group "test" already included when pylock file generated
@@ -35,10 +35,12 @@ elif [[ "${MNE_CI_KIND}" == "old" ]]; then
3535
elif [[ "${MNE_CI_KIND}" == "pip" ]]; then
3636
GROUP="test_extra"
3737
EXTRAS="[full-pyside6]"
38+
python -m pip install --upgrade pip setuptools
3839
else
3940
test "${MNE_CI_KIND}" == "pip-pre"
41+
python -m pip install $STD_ARGS pip setuptools
4042
STD_ARGS="$STD_ARGS --pre"
41-
${SCRIPT_DIR}/install_pre_requirements.sh || exit 1
43+
${SCRIPT_DIR}/install_pre_requirements.sh
4244
GROUP="test_extra"
4345
EXTRAS=""
4446
fi
@@ -58,5 +60,4 @@ else
5860
fi
5961
set -x
6062
python -m pip install $STD_ARGS $ONLY_BINARY_ARG $INSTALL_ARGS .$EXTRAS $GROUP_ARG
61-
set +x
6263
echo "::endgroup::"

tools/github_actions_env_vars.sh

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,14 @@ elif [[ "$MNE_CI_KIND" == "conda" ]]; then
2121
echo "MNE_LOGGING_LEVEL=warning" | tee -a $GITHUB_ENV
2222
echo "MNE_TEST_ALLOW_SKIP=.*(Requires (spm|brainstorm) dataset|CUDA not|PySide6 causes segfaults|Accelerate|Flakey verbose behavior).*" | tee -a $GITHUB_ENV
2323
# Our cache_dir test has problems when the path is too long, so prevent it from getting too long
24-
if [[ "$RUNNER_OS" == "macOS" ]]; then
24+
if [[ "$CI_OS_NAME" == "macos"* ]]; then
2525
echo "PYTEST_DEBUG_TEMPROOT=/tmp" | tee -a $GITHUB_ENV
2626
fi
2727
echo "MNE_QT_BACKEND=PySide6" | tee -a $GITHUB_ENV
2828
else
2929
echo "✕ ERROR: Unrecognized MNE_CI_KIND=${MNE_CI_KIND}"
3030
exit 1
3131
fi
32-
set +x
32+
if [[ "$CI_OS_NAME" == "windows"* ]]; then
33+
echo "MNE_IS_OSMESA=true" | tee -a $GITHUB_ENV
34+
fi

tools/github_actions_test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ else
2323
USE_DIRS="mne/"
2424
fi
2525
JUNIT_PATH="junit-results.xml"
26-
if [[ ! -z "$CONDA_ENV" ]] && [[ "${RUNNER_OS}" != "Windows" ]] && [[ "${MNE_CI_KIND}" != "minimal" ]] && [[ "${MNE_CI_KIND}" != "old" ]]; then
26+
if [[ ! -z "$CONDA_ENV" ]] && [[ "${CI_OS_NAME}" != "windows"* ]] && [[ "${MNE_CI_KIND}" != "minimal" ]] && [[ "${MNE_CI_KIND}" != "old" ]]; then
2727
PROJ_PATH="$(pwd)"
2828
JUNIT_PATH="$PROJ_PATH/${JUNIT_PATH}"
2929
# Use the installed version after adding all (excluded) test files

0 commit comments

Comments
 (0)