Skip to content

Commit b756157

Browse files
committed
address review from Dan
1 parent 16a6ea4 commit b756157

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

doc/development/contributing.rst

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -679,7 +679,6 @@ MNE-Python uses the following CI services:
679679

680680
If you are contributing for the first time, you may notice that `Github Actions`_
681681
jobs do not start automatically, or appear as "pending".
682-
683682
This is expected behavior. Github Actions requires **manual approval from a
684683
maintainer** before running jobs submitted by new contributors. This is a
685684
security measure to prevent misuse of CI resources.
@@ -689,13 +688,12 @@ As a result:
689688
- Github Actions jobs may remain in a *pending* or *not running* state
690689
- This does **not** indicate a problem with your code
691690

692-
Once a maintainer approves your pull request, Github Actions workflows will run.
693-
Future contributions will not require manual approval.
694-
695-
`CircleCI`_ requires to sign up for an account and link it with your github repository
696-
that you use to contribute to MNE-Python.
691+
Once you have at least one PR merged into the MNE-Python repository, future
692+
contributions will not require manual approval.
697693

698-
The tests will fail if you are not a registered user before you push your changes.
694+
`CircleCI`_ will not build the documentation unless the GitHub account of the PR's most recent commit
695+
is associated with a CircleCI account. Creating one is easy and free, choose "login with GitHub" on `CircleCI`_ to get started.
696+
If you do not do this, it will show up as a failing CI job.
699697

700698
Before opening or updating a PR, check locally:
701699

0 commit comments

Comments
 (0)