Skip to content

Commit ff724e1

Browse files
authored
ENH: add shape validation for scalars in LayeredMesh.update_overlay (#13990)
1 parent d2a7a69 commit ff724e1

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

mne/viz/_3d_overlay.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,15 @@ def update_overlay(self, name, scalars=None, colormap=None, opacity=None, rng=No
286286
if overlay is None:
287287
return
288288
if scalars is not None:
289+
scalars = np.asarray(scalars)
290+
if self.smooth_mat is not None:
291+
expected = self.smooth_mat.shape[1]
292+
else:
293+
expected = len(overlay._scalars)
294+
if scalars.shape != (expected,):
295+
raise ValueError(
296+
f"scalars must have shape ({expected},), got {scalars.shape}"
297+
)
289298
if self.smooth_mat is not None:
290299
scalars = self.smooth_mat.dot(scalars)
291300
overlay._scalars = scalars

0 commit comments

Comments
 (0)