Implement data skip in samples#13270
Open
papadop wants to merge 6 commits into
Open
Conversation
Member
|
Do you have or could you create some tiny test file that has this attribute that we could add to mne-testing-data? |
Contributor
Author
|
I will do that. Would a variant of intervalrecording_raw.fif be OK (at 12MB not sure it can be considered as tiny) ? If it is, I already have it, it will just remain to write the test down. Otherwise, I need to create a smaller one which would require a bit more time (but normally it shouldn't be too difficult). |
Member
|
Ideally < 1 MB would be better so if you can shrink it please do! |
Contributor
Author
|
OK. Will do. |
Member
|
@papadop just a friendly ping about this one in case you have time to come back to it! |
Contributor
Author
|
Thanks for the reminder. I'll try to do it in the coming days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
None
What does this implement/fix?
This implements the handling of the tag FIFF_DATA_SKIP_SAMP.
It does it by adding the handling of the tag in the reading loop.
Also, the implementation of the initial data skip is changed by leveraging the in-loop reading code instead of duplicating it as it was. In addition, the new code should handle correctly multiple FIFF_DATA_SKIP_SAMP or FIFF_DATA_SKIP, which was not the case previsouly.
Additional information
Fiff documentation states:
This patch does it.
This is not a feature used that often, but since it is documented that way....