Tweak y-axis label#13298
Conversation
|
@drammock I tried to make the docstring slightly more readable, but the _dB = """
dB : bool
Whether to plot on a decibel scale. If ``True``, plots
10 × log₁₀({quantity}){caveat}.{extra}
"""I would like to change the following three things:
|
|
I think this is good to go even without the three minor tweaks to the docs. |
The code handles the 10 vs 20 coefficient here, a few lines up from the lines you edited in this PR.
We never pass anything to scipy.signal.spectrum's scaling param, which means it's always "density" and therefore always
I think we can't easily do that actually, as the reference value units will change for mags, grads, or EEG. I think we really do need to keep the reference value in the y-axis label. |
|
Thanks @drammock! I'm not happy with keeping the reference in the label, but it's at least better than before. Can you remove the colon so that at least there's one less character cluttering the label? Thanks also for helping with the other points. |
|
Feel free to add yourself to the changelog BTW! |
|
@cbrnr FYI force-pushing here makes it a bit harder to figure out why the tests were failing (as we lose easy access to CI logs from past commits through the GitHub UI). not sure exactly why you force-pushed, but maybe next time |
|
Yeah, I force push out of habit after rebasing, but I'll keep that in mind next time! |
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Use more common y-axis label for PSD plot. Fixes #13296.