Rename devel to dev#13349
Conversation
cbrnr
requested review from
agramfort,
dengemann,
drammock and
larsoner
as code owners
|
Massive diff for such a tiny change, let's see if this works. |
|
Docs are failing due to The pip pre check is also failing because it tries to check out a non-existing branch |
| [ | ||
| { | ||
| "name": "1.11 (devel)", | ||
| "name": "1.11 (dev)", |
There was a problem hiding this comment.
-1 on changing the changelog folder name. It's not user-facing. This change is the only one I expected you to make.
There was a problem hiding this comment.
OK, but why not be consistent even for devs? Do you expect any problems if we change it?
There was a problem hiding this comment.
I don't foresee specific problems, but that doesn't guarantee there won't be any. To me, the effort & risk of unforeseen problems far outweigh the gain here. If you insist on changing the foldername, then we (you) should also do a .git-blame-ignore-revs entry for that change (which, ideally, means separating it from the change to the versions.json file).
There was a problem hiding this comment.
As @larsoner noted, I've reverted changes to the history files in doc/sphinxext/prs, so now I think the remaining changes are small and also should not require a .git-blame-ignore-revs entry.
|
Failure looks like an unrelated |
|
Failure is real it needs a |
|
Test Ultraslow_PG errors are unrelated I think. |
larsoner
added
skip-changelog-checks
no-changelog-entry-needed
and removed
no-changelog-entry-needed
skip-changelog-checks
labels
3 participants
Fixes #13348.