-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
FIX: short-circuit n_jobs=None to n_jobs=1 without Parallel setup #13777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2f0f897
short-circuit n_jobs=None
skjerns acbcd0a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] bba98d2
fix prehooks
skjerns bd852fd
fix prehooks
skjerns c155dc3
fix merge
skjerns a4543cf
add towncrier rst
skjerns e9e3850
fix tests
skjerns cbee155
Update doc/changes/dev/13777.bugfix.rst
skjerns bb115e6
Merge branch 'main' into fix_njobs_none
skjerns 614c242
skip test on windows
skjerns ddb56c3
Merge branch 'fix_njobs_none' of github.com:skjerns/mne-python into f…
skjerns 72d2812
Merge branch 'main' into fix_njobs_none
skjerns 51bb75f
[autofix.ci] apply automated fixes
autofix-ci[bot] a0484b0
Merge branch 'main' into fix_njobs_none
skjerns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Avoid some unnecessary computations when ``n_jobs=None`` is equivalent to ``n_jobs=1``, by `Simon Kern`_. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this doesn't work on Windows, but I know there are some quirks there (e.g., this). Maybe for simplicity just skip this test on Windows and add a TODO comment to look into it someday...?