ENH: group triaxial OPM topomaps by orientation#13866
ENH: group triaxial OPM topomaps by orientation#13866PragnyaKhandelwal wants to merge 11 commits intomne-tools:mainfrom
Conversation
for more information, see https://pre-commit.ci
|
Hi @larsoner....Just a friendly ping on this final wrap-up for the OPM topomaps. I've included visual outputs in the PR description showing the new grouped views. Ready to review whenever you have a chance! |
|
Code looks reasonable at first look. But now I'm wondering whether or not this can be combined / refactored with the mag/grad code for Neuromag systems. The problem is similar there: there are three sensors per location, one radial (magnetometer) and two tangential (gradiometers) and we plot the mags in one plot and the RMS of the gradiometers in another. Do you think it's worth looking into that refactoring in this PR? Or would it be better to review + merge this PR as-is and then refactor afterward? |
|
Thanks @larsoner! I completely agree that unifying the OPM and Neuromag mag/grad logic is the right architectural direction since the underlying radial/tangential problem is so similar. |
|
Yeah that sounds reasonable to me! One last request, can you modify some example(s)/tutorial(s) in a way that shows this new functionality? |
…yaKhandelwal/mne-python into enh-opm-grouping-final-fix
…oad timeout in CI
|
Thanks @larsoner! I've added a new example demonstrating the grouped triaxial OPM topomaps using Well I initially tried using the Ready for final review and merge once these last CI checks turn green! |
Hmmm that's a problem, that's a real dataset and it should work on real data. Can you try running it with memory profiler for example to see if memory usage goes too high? It really shouldn't for evoked data... if you can push a commit that should work (or revert to one that should) I can also look A fake triaxial dataset I think is less useful for people. |
Reference issue (if any)
Closes #13781
What does this implement/fix?
Final fix for #13781: adds caller-facing grouped rendering for colocated triaxial OPM channels so orientation information is shown explicitly across visualization entry points.
Implemented:
Additional information
Manual visual check done for:
Evoked.plot_topomapgrouped radial/tangential mapsEvoked.plot_jointgrouped maps + connector linesICA.plot_componentsgrouped radial/tangential titlesA local helper script was used for manual visual smoke-checking on synthetic triaxial OPM data. I can share it if needed.
Visual outputs: