BUG: improve FreeSurfer error message when executable not found#13874
Open
ayuclan wants to merge 6 commits intomne-tools:mainfrom
Open
BUG: improve FreeSurfer error message when executable not found#13874ayuclan wants to merge 6 commits intomne-tools:mainfrom
ayuclan wants to merge 6 commits intomne-tools:mainfrom
Conversation
When mri_watershed is not found, raise a RuntimeError with clear guidance to check FREESURFER_HOME, PATH, and shell configuration. Closes mne-tools#12917 Re-submission of mne-tools#13790
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
wmvanvliet
reviewed
Apr 28, 2026
| .. _Jukka Nenonen: https://www.linkedin.com/pub/jukka-nenonen/28/b5a/684 | ||
| .. _Jussi Nurminen: https://github.com/jjnurminen | ||
| .. _Kaisu Lankinen: http://bishoplab.berkeley.edu/Kaisu.html | ||
| .. _Kalle Makela: https://github.com/Kallemakela |
Author
There was a problem hiding this comment.
Sorry about that! The accidental deletions were caused by Ctrl+Z in my editor. I've restored all the missing entries now.
ayuclan
force-pushed
the
fix-freesurfer-error-v2
branch
from
a16bfb7 to
e283134
Compare
ayuclan
force-pushed
the
fix-freesurfer-error-v2
branch
from
7e59ac1 to
0d4f084
Compare
for more information, see https://pre-commit.ci
Contributor
|
Looks like opening a new PR fixed the doc build! |
larsoner
approved these changes
Apr 28, 2026
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
@wmvanvliet I just pushed a commit to fix the changelog, feel free to mark for merge-when-green when you're happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12917
Improves the error message in make_watershed_bem() when the FreeSurfer
executable (mri_watershed) cannot be found.
Instead of a generic FileNotFoundError, users now get a clear RuntimeError
explaining:
The original FileNotFoundError is chained using
from efor full traceback.This is a re-submission of #13790, which had unresolvable CI issues
unrelated to the code changes. The fix itself was reviewed and approved
by @wmvanvliet .