ENH: Allow passing source detector distances to beer lambert law#13875
Open
Kallemakela wants to merge 7 commits intomne-tools:mainfrom
Open
Conversation
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
Kallemakela
requested review from
agramfort,
drammock and
larsoner
as code owners
larsoner
reviewed
Apr 28, 2026
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Looks reasonable to me, but CIs are not happy. Can you investigate ?
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
#13862
What does this implement/fix?
Add an optional sd_distances argument to mne/preprocessing/nirs/_beer_lambert_law.py:17.
Proposed signature:
def beer_lambert_law(raw, ppf=6.0, sd_distances=None):
Example usage:
beer_lambert_law(raw_od, sd_distances=0.03)
beer_lambert_law(raw_od, sd_distances=[0.03, 0.03, 0.03, 0.03]) # matches info['chs'] order
Additional information