Skip to content

Add spherical montages#13903

Merged
larsoner merged 11 commits into
mne-tools:mainfrom
cbrnr:standard-montages
May 22, 2026
Merged

Add spherical montages#13903
larsoner merged 11 commits into
mne-tools:mainfrom
cbrnr:standard-montages

Conversation

@cbrnr
Copy link
Copy Markdown
Contributor

@cbrnr cbrnr commented May 19, 2026

Fixes #7141. I used the 3D location files from here.

1020 1010 1005

Copy link
Copy Markdown
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the effort @cbrnr

I do think we should insert references about where the colin and spherical locations come from (fieldtrip/robert and eeg_positions, respectively). Just so that we have a clear documentation of the provenance.

As for where, I am open.

Copy link
Copy Markdown
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think we should insert references about where the colin and spherical locations come from (fieldtrip/robert and eeg_positions, respectively). Just so that we have a clear documentation of the provenance.

How about a new mne/channels/data/montages/provenance.rst (or .md or .txt)? Can keep it as dev-level info for now I think and we just want some way to document it clearly. We can start this new file with just info for the stuff added here, but @cbrnr if you want to dig into the history of the other files and add it here that's great too.

Maybe someday in the future we can add to some docstring or something if needed, by I'd assume YAGNI / not enough benefit to doing it for now

@cbrnr next time you push a commit can you put [circle full] in the commit message? Should help ensure no examples break. (CircleCI will already run the examples you modified here, but the commit-message trick will help ensure errors in other, non-modified examples aren't missed.)

Comment thread doc/changes/dev/13903.newfeature.rst Outdated
Comment thread mne/channels/_standard_montage_utils.py
@cbrnr
Copy link
Copy Markdown
Contributor Author

cbrnr commented May 22, 2026

@larsoner all done!

Copy link
Copy Markdown
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tweak, will push the suggested commit with [circle full] and mark for merge-when-green, thanks in advance @cbrnr !

Comment thread tutorials/forward/35_eeg_no_mri.py Outdated
@larsoner larsoner enabled auto-merge (squash) May 22, 2026 17:29
@drammock drammock disabled auto-merge May 22, 2026 18:07
Comment thread tutorials/forward/35_eeg_no_mri.py Outdated
Co-authored-by: Daniel McCloy <dan@mccloy.info>
@larsoner larsoner merged commit db75c70 into mne-tools:main May 22, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default standard_1020 montage contains realistic, not template positions

4 participants