Skip to content

FIX: Avoid iteration errors caused by None when reading Nihon Kohden .LOG files #13915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsoner merged 2 commits into from
May 26, 2026
+6 −3
Merged

FIX: Avoid iteration errors caused by None when reading Nihon Kohden .LOG files #13915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
634e3e3
Fix: Avoid iteration errors caused by None when reading Nihon Kohden …
myd7349 May 24, 2026
bdd517a
Update doc/changes/dev/13915.bugfix.rst
larsoner May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/dev/13915.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix iteration errors in :func:`mne.io.read_raw_nihon` when reading log files, by `Tom Ma`_.
8 changes: 5 additions & 3 deletions mne/io/nihon/nihon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,21 +289,23 @@ def _read_nihon_header(fname):


def _read_event_log_block(fid, t_block, version):
empty_logs = np.empty(0, dtype="|S45")

fid.seek(0x92 + t_block * 20)
data = np.fromfile(fid, np.uint32, 1)
if data.size == 0 or data[0] == 0:
return
return empty_logs
t_blk_address = data[0]

fid.seek(t_blk_address + 0x1)
data = np.fromfile(fid, "|S16", 1).astype("U16")
if data.size == 0 or data[0] != version:
return
warn(f"Event log version mismatch: expected '{version}', got '{data}'")

fid.seek(t_blk_address + 0x12)
data = np.fromfile(fid, np.uint8, 1)
if data.size == 0:
return
return empty_logs
n_logs = data[0]

fid.seek(t_blk_address + 0x14)
Expand Down