Skip to content

Commit d9829c9

Browse files
authored
Merge pull request #73 from mngoe/feature-36775-hotfix
fix save invalid diagnosis
2 parents 364d4dd + 20f8143 commit d9829c9

4 files changed

Lines changed: 36 additions & 2 deletions

File tree

claimManagement/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ android {
2727
minSdkVersion 26
2828
targetSdkVersion 32
2929
versionCode 4
30-
versionName System.getenv("APP_VERSION") ?: "2.3.9"
30+
versionName System.getenv("APP_VERSION") ?: "2.4.0"
3131
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
3232
}
3333
buildTypes {

claimManagement/src/main/java/org/openimis/imisclaims/ClaimActivity.java

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ public void onItemClick(AdapterView<?> adapterView, View view, int position, lon
267267
btnPost.setOnClickListener(v -> {
268268
progressDialog = ProgressDialog.show(this, "", getResources().getString(R.string.Processing));
269269
runOnNewThread(
270-
() -> isValidData() && saveClaim(),
270+
() -> isValidData() && isValidDiagnosis() && saveClaim(),
271271
() -> runOnUiThread(() -> {
272272
ClearForm();
273273
progressDialog.dismiss();
@@ -832,6 +832,11 @@ private boolean isValidData() {
832832
return false;
833833
}
834834

835+
if(!isValidProgram()){
836+
showValidationDialog(etProgram, getResources().getString(R.string.InvalidProgram));
837+
return false;
838+
}
839+
835840
if(etClaimPrefix.getText().length() == 0){
836841
showValidationDialog(etClaimPrefix, getResources().getString(R.string.MissingChequeNumber));
837842
return false;
@@ -875,6 +880,31 @@ private boolean isValidInsureeNumber() {
875880
return escape.CheckCHFID(etInsureeNumber.getText().toString());
876881
}
877882

883+
private boolean isValidDiagnosis(){
884+
List<AutoCompleteTextView> diagnosisList = new ArrayList<>();
885+
diagnosisList.add(etDiagnosis);
886+
diagnosisList.add(etDiagnosis1);
887+
diagnosisList.add(etDiagnosis2);
888+
diagnosisList.add(etDiagnosis3);
889+
diagnosisList.add(etDiagnosis4);
890+
891+
for(AutoCompleteTextView diagnosis : diagnosisList){
892+
if(!diagnosis.getText().toString().isEmpty()){
893+
int diagnosisId = sqlHandler.getDiagnosisId(diagnosis.getText().toString());
894+
if(diagnosisId == 0){
895+
showValidationDialog(diagnosis, getResources().getString(R.string.invalidDisease));
896+
return false;
897+
}
898+
}
899+
}
900+
return true;
901+
}
902+
903+
private boolean isValidProgram(){
904+
int programId = sqlHandler.getProgamId(etProgram.getText().toString());
905+
return programId != 0;
906+
}
907+
878908
protected void showValidationDialog(View view, String msg) {
879909
runOnUiThread(() -> showDialog(msg, (dialog, which) -> {
880910
if (view instanceof EditText) {

claimManagement/src/main/res/values-fr/strings.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -565,4 +565,6 @@
565565
<string name="updateAvailable">Mise à jour disponible</string>
566566
<string name="haveLastVersion">Vous avez la dernière version </string>
567567
<string name="newVersion">Nouvelle version </string>
568+
<string name="invalidDisease">Code de diagnostic invalide</string>
569+
<string name="InvalidProgram">Le programme saisi est invalide</string>
568570
</resources>

claimManagement/src/main/res/values/strings.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,4 +249,6 @@
249249
<string name="updateAvailable">Update available</string>
250250
<string name="haveLastVersion">You have the last version </string>
251251
<string name="newVersion">New version </string>
252+
<string name="invalidDisease">Invalid disease code</string>
253+
<string name="InvalidProgram">Invalid program</string>
252254
</resources>

0 commit comments

Comments
 (0)