Skip to content

Commit 59abe4c

Browse files
authored
fix(client): sidebar font & profile placeholders (freeCodeCamp#65974)
1 parent e020939 commit 59abe4c

2 files changed

Lines changed: 26 additions & 2 deletions

File tree

client/src/client-only-routes/show-settings.css

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,37 @@
1313
padding-left: 0;
1414
}
1515

16-
.settings-sidebar-nav ul li {
16+
.settings-sidebar-nav > ul > li {
1717
margin-bottom: 0.5rem;
1818
}
1919

20+
.settings-sidebar-nav ul ul li {
21+
margin-bottom: 0.15rem;
22+
}
23+
2024
.settings-sidebar-nav {
2125
flex: 1;
2226
position: sticky;
2327
top: var(--header-height);
2428
padding: 1rem 0;
25-
overflow-y: scroll;
29+
overflow-y: auto;
2630
height: calc(100vh - var(--header-height));
2731
border-right: 3px solid var(--tertiary-background);
32+
scrollbar-width: thin;
33+
scrollbar-color: var(--quaternary-background) var(--secondary-background);
34+
}
35+
36+
.settings-sidebar-nav::-webkit-scrollbar {
37+
width: 6px;
38+
}
39+
40+
.settings-sidebar-nav::-webkit-scrollbar-track {
41+
background: var(--secondary-background);
42+
}
43+
44+
.settings-sidebar-nav::-webkit-scrollbar-thumb {
45+
background-color: var(--quaternary-background);
46+
border-radius: 3px;
2847
}
2948

3049
.settings-sidebar-nav .sidebar-nav-section-heading {
@@ -43,6 +62,7 @@
4362
text-decoration: none;
4463
cursor: pointer;
4564
padding: 0 1rem 0rem 2rem;
65+
font-size: 0.85rem;
4666
}
4767

4868
.settings-sidebar-nav .sidebar-nav-section-heading.active,

client/src/components/profile/components/about.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,7 @@ const AboutSettings = ({
180180
type='text'
181181
value={formValues.name}
182182
id='about-name-input'
183+
placeholder='Camper Bot'
183184
/>
184185
</FormGroup>
185186
<FormGroup controlId='about-location'>
@@ -191,6 +192,7 @@ const AboutSettings = ({
191192
type='text'
192193
value={formValues.location}
193194
id='about-location-input'
195+
placeholder='San Francisco, CA'
194196
/>
195197
</FormGroup>
196198
<FormGroup controlId='about-picture'>
@@ -202,6 +204,7 @@ const AboutSettings = ({
202204
type='url'
203205
value={formValues.picture}
204206
id='about-picture-input'
207+
placeholder='https://github.com/ghost.png'
205208
/>
206209
{!isPictureUrlValid && (
207210
<ShowImageValidationWarning
@@ -218,6 +221,7 @@ const AboutSettings = ({
218221
onChange={handleAboutChange}
219222
value={formValues.about}
220223
id='about-about-input'
224+
placeholder='A short bio about yourself'
221225
/>
222226
</FormGroup>
223227
</div>

0 commit comments

Comments
 (0)