Skip to content

Commit b6d0663

Browse files
authored
feat(Curriculum): add 1 Spanish character and 2 Chinese (freeCodeCamp#66550)
1 parent 660f39d commit b6d0663

4 files changed

Lines changed: 42 additions & 7 deletions

File tree

client/src/redux/prop-types.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ export type Characters =
117117
| 'Tom'
118118

119119
// Spanish
120-
| 'Alex'
121120
| 'Ángela'
122121
| 'Camila'
123122
| 'Carlos'
@@ -137,12 +136,14 @@ export type Characters =
137136

138137
// Chinese
139138
| 'Chen Na'
139+
| 'Huang Jingyi'
140140
| 'Li Hong'
141141
| 'Li Ping'
142142
| 'Lin Yating'
143143
| 'Liu Ming'
144144
| 'Wang Hua'
145145
| 'Zhang Wei'
146+
| 'Zhou Jia'
146147
| 'Zhou Yongjie';
147148

148149
interface SetupCharacter {

client/src/templates/Challenges/components/scene/scene-assets.tsx

Lines changed: 34 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,20 @@ const character = {
3838
marisol: `${characters}/marisol`,
3939
mateo: `${characters}/mateo`,
4040
noelia: `${characters}/noelia`,
41+
rene: `${characters}/rene`,
4142
sebastian: `${characters}/sebastian`,
4243
valeria: `${characters}/valeria`,
4344

4445
// Chinese
4546
chenNa: `${characters}/chen-na`,
47+
huangJingyi: `${characters}/huang-jingyi`,
4648
liHong: `${characters}/li-hong`,
4749
liPing: `${characters}/li-ping`,
4850
linYating: `${characters}/lin-yating`,
4951
liuMing: `${characters}/liu-ming`,
5052
wangHua: `${characters}/wang-hua`,
5153
zhangWei: `${characters}/zhang-wei`,
54+
zhouJia: `${characters}/zhou-jia`,
5255
zhouYongjie: `${characters}/zhou-yongjie`
5356
};
5457

@@ -325,6 +328,15 @@ const characterImages = {
325328
mouthClosed: `${character.noelia}/mouth-smile.png`,
326329
mouthOpen: `${character.noelia}/mouth-open.png`
327330
},
331+
rene: {
332+
base: `${character.rene}/base.png`,
333+
brows: `${character.rene}/brows-neutral.png`,
334+
eyesClosed: `${character.rene}/eyes-closed.png`,
335+
eyesOpen: `${character.rene}/eyes-open.png`,
336+
glasses: null,
337+
mouthClosed: `${character.rene}/mouth-smile.png`,
338+
mouthOpen: `${character.rene}/mouth-open.png`
339+
},
328340
sebastian: {
329341
base: `${character.sebastian}/base.png`,
330342
brows: `${character.sebastian}/brows-neutral.png`,
@@ -353,6 +365,15 @@ const characterImages = {
353365
mouthClosed: `${character.chenNa}/mouth-smile.png`,
354366
mouthOpen: `${character.chenNa}/mouth-open.png`
355367
},
368+
huangJingyi: {
369+
base: `${character.huangJingyi}/base.png`,
370+
brows: `${character.huangJingyi}/brows-neutral.png`,
371+
eyesClosed: `${character.huangJingyi}/eyes-closed.png`,
372+
eyesOpen: `${character.huangJingyi}/eyes-open.png`,
373+
glasses: null,
374+
mouthClosed: `${character.huangJingyi}/mouth-smile.png`,
375+
mouthOpen: `${character.huangJingyi}/mouth-open.png`
376+
},
356377
liHong: {
357378
base: `${character.liHong}/base.png`,
358379
brows: `${character.liHong}/brows-neutral.png`,
@@ -407,6 +428,15 @@ const characterImages = {
407428
mouthClosed: `${character.zhangWei}/mouth-smile.png`,
408429
mouthOpen: `${character.zhangWei}/mouth-open.png`
409430
},
431+
zhouJia: {
432+
base: `${character.zhouJia}/base.png`,
433+
brows: `${character.zhouJia}/brows-neutral.png`,
434+
eyesClosed: `${character.zhouJia}/eyes-closed.png`,
435+
eyesOpen: `${character.zhouJia}/eyes-open.png`,
436+
glasses: null,
437+
mouthClosed: `${character.zhouJia}/mouth-smile.png`,
438+
mouthOpen: `${character.zhouJia}/mouth-open.png`
439+
},
410440
zhouYongjie: {
411441
base: `${character.zhouYongjie}/base.png`,
412442
brows: `${character.zhouYongjie}/brows-neutral.png`,
@@ -446,7 +476,6 @@ export const characterAssets = {
446476
Tom: characterImages.tom,
447477

448478
// Spanish
449-
Alex: characterImages.npcGirl,
450479
Ángela: characterImages.angela,
451480
Camila: characterImages.camila,
452481
Carlos: characterImages.carlos,
@@ -459,18 +488,20 @@ export const characterAssets = {
459488
Marisol: characterImages.marisol,
460489
Mateo: characterImages.mateo,
461490
Noelia: characterImages.noelia,
462-
René: characterImages.npcMan,
491+
René: characterImages.rene,
463492
Sebastián: characterImages.sebastian,
464493
Diego: characterImages.diego,
465494
Valeria: characterImages.valeria,
466495

467-
//Chinese
496+
// Chinese
468497
'Chen Na': characterImages.chenNa,
498+
'Huang Jingyi': characterImages.huangJingyi,
469499
'Li Hong': characterImages.liHong,
470500
'Li Ping': characterImages.liPing,
471501
'Lin Yating': characterImages.linYating,
472502
'Liu Ming': characterImages.liuMing,
473503
'Wang Hua': characterImages.wangHua,
474504
'Zhang Wei': characterImages.zhangWei,
505+
'Zhou Jia': characterImages.zhouJia,
475506
'Zhou Yongjie': characterImages.zhouYongjie
476507
};

curriculum/schema/__snapshots__/challenge-schema.test.mjs.snap

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1414,7 +1414,6 @@ exports[`challenge schema > should not be changed without informing the mobile t
14141414
"Second Candidate",
14151415
"Sophie",
14161416
"Tom",
1417-
"Alex",
14181417
"Ángela",
14191418
"Camila",
14201419
"Carlos",
@@ -1432,12 +1431,14 @@ exports[`challenge schema > should not be changed without informing the mobile t
14321431
"Diego",
14331432
"Valeria",
14341433
"Chen Na",
1434+
"Huang Jingyi",
14351435
"Li Hong",
14361436
"Li Ping",
14371437
"Lin Yating",
14381438
"Liu Ming",
14391439
"Wang Hua",
14401440
"Zhang Wei",
1441+
"Zhou Jia",
14411442
"Zhou Yongjie",
14421443
],
14431444
"flags": {
@@ -1910,7 +1911,6 @@ exports[`challenge schema > should not be changed without informing the mobile t
19101911
"Second Candidate",
19111912
"Sophie",
19121913
"Tom",
1913-
"Alex",
19141914
"Ángela",
19151915
"Camila",
19161916
"Carlos",
@@ -1928,12 +1928,14 @@ exports[`challenge schema > should not be changed without informing the mobile t
19281928
"Diego",
19291929
"Valeria",
19301930
"Chen Na",
1931+
"Huang Jingyi",
19311932
"Li Hong",
19321933
"Li Ping",
19331934
"Lin Yating",
19341935
"Liu Ming",
19351936
"Wang Hua",
19361937
"Zhang Wei",
1938+
"Zhou Jia",
19371939
"Zhou Yongjie",
19381940
],
19391941
"flags": {

curriculum/schema/scene-assets.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ const availableCharacters = [
2525
'Tom',
2626

2727
// Spanish
28-
'Alex',
2928
'Ángela',
3029
'Camila',
3130
'Carlos',
@@ -45,12 +44,14 @@ const availableCharacters = [
4544

4645
// Chinese
4746
'Chen Na',
47+
'Huang Jingyi',
4848
'Li Hong',
4949
'Li Ping',
5050
'Lin Yating',
5151
'Liu Ming',
5252
'Wang Hua',
5353
'Zhang Wei',
54+
'Zhou Jia',
5455
'Zhou Yongjie'
5556
];
5657

0 commit comments

Comments
 (0)