Skip to content

Commit ddedbbc

Browse files
authored
refactor(tooling,client): add html-eslint/react and fix lint errors (freeCodeCamp#66015)
1 parent a37824b commit ddedbbc

5 files changed

Lines changed: 203 additions & 17 deletions

File tree

client/src/components/Donation/donate-form.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ const mapDispatchToProps = {
112112

113113
const PaymentButtonsLoader = () => {
114114
return (
115-
<div className=' donation-completion donation-completion-loading'>
115+
<div className='donation-completion donation-completion-loading'>
116116
<Spinner
117117
className='script-loading-spinner'
118118
fadeIn='none'

client/src/templates/Challenges/components/independent-lower-jaw.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ export function IndependentLowerJaw({
203203
ref={submitButtonRef}
204204
>
205205
{t('buttons.submit-continue')}
206-
<span className='tooltiptext left-tooltip '>
206+
<span className='tooltiptext left-tooltip'>
207207
{checkButtonText}
208208
</span>
209209
</Button>
@@ -215,7 +215,7 @@ export function IndependentLowerJaw({
215215
onClick={handleCheckButtonClick}
216216
>
217217
{t('buttons.check-code')}
218-
<span className='tooltiptext left-tooltip '>
218+
<span className='tooltiptext left-tooltip'>
219219
{checkButtonText}
220220
</span>
221221
</button>

packages/eslint-config/base.js

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import importPlugin from 'eslint-plugin-import';
1212
import testingLibraryPlugin from 'eslint-plugin-testing-library';
1313
import babelParser from '@babel/eslint-parser'; // TODO: can we get away from using babel?
1414
import turbo from 'eslint-plugin-turbo';
15+
import htmlReact from '@html-eslint/eslint-plugin-react';
1516

1617
import { FlatCompat } from '@eslint/eslintrc';
1718

@@ -131,7 +132,17 @@ export const configReact = [
131132
compat.extends(
132133
'plugin:react-hooks/recommended' // Note: at time of testing, upgrading to v5 creates false positives
133134
)
134-
)
135+
),
136+
{
137+
plugins: {
138+
'@html-eslint/react': htmlReact
139+
},
140+
rules: {
141+
'@html-eslint/react/no-duplicate-classname': 'error',
142+
'@html-eslint/react/classname-spacing': 'error',
143+
'@html-eslint/react/no-ineffective-attrs': 'error'
144+
}
145+
}
135146
];
136147

137148
export const configTestingLibrary = defineConfig({

packages/eslint-config/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
"@eslint/compat": "^1.2.6",
1616
"@eslint/eslintrc": "^3.2.0",
1717
"@eslint/js": "^9.19.0",
18+
"@html-eslint/eslint-plugin-react": "^0.57.0",
1819
"@vitest/eslint-plugin": "^1.4.3",
1920
"eslint": "^9.39.1",
2021
"eslint-config-prettier": "10.0.1",

0 commit comments

Comments
 (0)