fix(web): handle stale iframe in fetchCrossOriginIframeContent#3314
Merged
Conversation
Move switchTo().frame() inside the existing try/catch so a StaleElementReferenceException (iframe removed between findElement and switchTo on dynamic pages) degrades to a null return instead of escaping the method. Mirrors the same fix in CdpWebDriver.
Mock switchTo().frame() to throw StaleElementReferenceException and assert the method returns null (graceful skip) instead of propagating.
Contributor
|
Related to #3289 ? |
Contributor
Author
|
Hey @proksh, can i get insight if you'd want me to revert changes in 3289 and make it more targeted? |
Contributor
Author
Reviewed and left comments on your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
switchTo().frame()sat outside the try/catch infetchCrossOriginIframeContent, so aStaleElementReferenceException(iframe removed/replaced betweenfindElementandswitchToon dynamic pages) escaped the method instead of degrading to the samenullreturn every other failure already produces. Caller already handlesnullby emitting an empty-children placeholder, so the hierarchy renders without the cross-origin iframe and the test continues.Mirrors the same fix into
CdpWebDriver.