Skip to content

Commit c7090fc

Browse files
jkraemerintelfx
authored andcommitted
Add an empty virtual destructor to OutOfBandPlugin
I encountered this during dpkg-buildpackage on Debian Jessie: outofband.h:118:9: error: ‘class Network::OutOfBandPlugin’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]
1 parent 346725c commit c7090fc

2 files changed

Lines changed: 3 additions & 0 deletions

File tree

src/network/outofband.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -321,3 +321,5 @@ string OutOfBandCommunicator::read(size_t len) {
321321
stream_buf = stream_buf.substr(len);
322322
return rv;
323323
}
324+
325+
OutOfBandPlugin::~OutOfBandPlugin() { }

src/network/outofband.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ namespace Network {
125125
virtual void close_sessions( void ) = 0;
126126
virtual void shutdown( void ) = 0;
127127
virtual void attach_oob(Network::OutOfBand *oob_ctl) = 0;
128+
virtual ~OutOfBandPlugin() = 0;
128129

129130
friend class OutOfBand;
130131
};

0 commit comments

Comments
 (0)