cache/remotecache: normalize object cache layer media types#6913
Open
crazy-max wants to merge 1 commit into
Open
cache/remotecache: normalize object cache layer media types#6913crazy-max wants to merge 1 commit into
crazy-max wants to merge 1 commit into
Conversation
tonistiigi
reviewed
Jul 3, 2026
tonistiigi
left a comment
Member
There was a problem hiding this comment.
Not sure about this approach:
- Afaics the registry/local cache already defaulted to OCI. So not sure if this is changing anything about them. This seems to handle
gha/s3/azblob, but in there I think it is only relevant to theCacheLayer.Annotations. I don't think it would require configurability there as these should be pretty much internal annotations. - Compatibility-version is only for release artifact reproducibility. I don't think we should extend it for exported cache and the current versions were not handling it(probably not even possible to keep this as guarantee).
Member
Author
Ah makes sense, I will get rid of compatibility changes. |
b8b1d71 to
83ee691
Compare
83ee691 to
b1acc9b
Compare
Member
Author
|
@tonistiigi I reworked this to keep the change scoped to the object cache exporters. Removed the compatibility version and removes the finalize option plumbing. Registry and local cache exporters are also back to their previous behavior, so their existing The remaining change is only for GHA, S3, and Azure Blob cache exporters. They now serialize |
b1acc9b to
9d45128
Compare
tonistiigi
reviewed
Jul 6, 2026
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
9d45128 to
cd5af67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up #6824
Updates remote cache chain marshaling so layer descriptors are normalized to OCI media types when descriptor media types are recorded.
This makes cache metadata written by the GHA, S3, and Azure Blob cache exporters store OCI layer media types in
CacheLayer.Annotations. Registry and local cache exporters keep their existing exported manifest behavior through theiroci-mediatypesoption.This doesn't add a new
compatibility-versionpath because the affected cache metadata is internal to the remote cache backends.