Skip to content

Commit 55196b1

Browse files
authored
Merge pull request #229 from thaJeztah/user_deref_sgids
user: GetExecUser: always clone default Sgids
2 parents ba3de4c + 94f7eb4 commit 55196b1

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

user/user.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -296,15 +296,10 @@ func GetExecUser(userSpec string, defaults *ExecUser, passwd, group io.Reader) (
296296
user := &ExecUser{
297297
Uid: defaults.Uid,
298298
Gid: defaults.Gid,
299-
Sgids: defaults.Sgids,
299+
Sgids: append([]int{}, defaults.Sgids...), // Sgids slice *cannot* be nil.
300300
Home: defaults.Home,
301301
}
302302

303-
// Sgids slice *cannot* be nil.
304-
if user.Sgids == nil {
305-
user.Sgids = []int{}
306-
}
307-
308303
// Allow for userSpec to have either "user", or optionally "user:group" syntax.
309304
userArg, groupArg, _ := strings.Cut(userSpec, ":")
310305

0 commit comments

Comments
 (0)