[WIP] user: skip malformed and empty lines#230
Draft
thaJeztah wants to merge 3 commits into
Draft
Conversation
thaJeztah
force-pushed
the
parseparts_err
branch
2 times, most recently
from
1b8a8f3 to
36088f5
Compare
Return an error when failing to parse numeric values instead of silently discarding them. Co-authored-by: Mickael Emirkanian <mickael.emirkanian@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
thaJeztah
commented
Jul 8, 2026
Comment on lines
+157
to
+161
| ok, err := parseLine(line, &p.Name, &p.Pass, &p.Uid, &p.Gid, &p.Gecos, &p.Home, &p.Shell) | ||
| if err != nil || !ok { | ||
| // Skip malformed and empty lines, and don't consider them. | ||
| continue | ||
| } |
Member
Author
There was a problem hiding this comment.
Possibly also skip zero-records;
if p == (User{}) {
continue
}
thaJeztah
commented
Jul 8, 2026
Comment on lines
+220
to
227
| ok, err := parseLine(line, &p.Name, &p.Pass, &p.Gid, &p.List) | ||
| if err != nil || !ok { | ||
| // Skip malformed and empty lines, and don't consider them. | ||
| continue | ||
| } | ||
|
|
||
| if filter == nil || filter(p) { | ||
| out = append(out, p) |
Member
Author
There was a problem hiding this comment.
Here as well, but Group is not comparable (due to the List []string)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.