Internal Quality and Modernization

[jamesdbloom]

Overview

Tracking issue for internal code quality, modernization, and test coverage improvements. These do not add user-facing features but improve maintainability, performance, and future extensibility.

Sub-issues

• LogEventRequestAndResponse should only use the concrete type not RequestDefinition #2104 — Refactor LogEventRequestAndResponse to use concrete HttpRequest type
• re-investigate why does REST API and persistence use different JSON serialisation / deserialisation (i.e. DTO and normal Object respectively) #2105 — Investigate unifying JSON serialization between REST API and persistence
• Support Java Platform Module System (JPMS) #2108 — Java Platform Module System (JPMS) support
• Investigate Support for GraalVM (or modern JS engine) #2110 — GraalVM JavaScript engine for templates (replace Nashorn)
• add tests for grouping with logCorrelationId #2111 — Add tests for logCorrelationId grouping
• TLS Performance (locking removal) #2131 — TLS performance improvement (remove locking in SslContextFactory)

Notes

#2104 (type cleanup) and #2111 (test coverage) are small wins. #2131 (TLS perf) could measurably improve throughput. #2108 (JPMS) is large and blocked by Java 11 target. #2110 (GraalVM JS) is needed because Nashorn is deprecated. #2105 (serialization unification) is a large refactor with risk.

[jamesdbloom]

Resolved — Internal Quality and Modernization

All items from this tracking issue have been addressed:

Implemented

• LogEventRequestAndResponse should only use the concrete type not RequestDefinition #2104 — Refactor LogEventRequestAndResponse to use concrete HttpRequest type — Narrowed field/getter/setter from abstract RequestDefinition to concrete HttpRequest. Removed dead OpenAPIDefinition branch from DTO. Improves public API type safety for MockServerClient.retrieveRecordedRequestsAndResponses().

• add tests for grouping with logCorrelationId #2111 — Add tests for logCorrelationId grouping — Added 10 new tests in MockServerEventLogCorrelationIdTest covering verification (pass/fail), verification sequences (pass/fail), unique correlationId per verification, LogEntry propagation, clear log entries, and expectation clear correlationId propagation.

• TLS Performance (locking removal) #2131 — TLS performance (locking removal) — Replaced synchronized methods in NettySslContextFactory with volatile + double-checked locking. The hot path (cached SSL context, no rebuild needed) is now lock-free. Made rebuildTLSContext and rebuildServerTLSContext flags volatile in Configuration to fix a latent visibility bug.

• re-investigate why does REST API and persistence use different JSON serialisation / deserialisation (i.e. DTO and normal Object respectively) #2105 — Unify JSON serialization between REST API and persistence — Persistence now uses the same DTO-based serialization path as the REST API. Created TimeToLiveDTOPersistenceSerializer to preserve endDate in persisted files while using the unified DTO format.

Planned (deferred to future major version)

• Investigate Support for GraalVM (or modern JS engine) #2110 — GraalVM JavaScript engine — Blocked by Java 11 minimum (GraalVM JS requires Java 17+). Nashorn standalone (15.7, Dec 2024) remains actively maintained and sufficient. Full migration plan documented in docs/plans/java-17-migration.md.

• Support Java Platform Module System (JPMS) #2108 — JPMS support — Analysis and phased implementation plan documented in docs/plans/jpms-support.md. Phase 1 (Automatic-Module-Name) provides immediate value with minimal risk.

[jamesdbloom]

Commits

All sub-issues have been implemented or documented. Here are the commits:

Sub-issue	Commit	Description
#2104	f621bc7e1	Narrow LogEventRequestAndResponse to concrete HttpRequest type
#2111	e159d17d1	Add 10 tests for logCorrelationId grouping
#2131	fab4ca492	Replace synchronized TLS context methods with volatile + DCL
#2105	3a16da9b9	Unify JSON serialization between REST API and persistence
#2110	31a0b3cb8	Java 17 migration plan (GraalVM JS deferred — requires Java 17+)
#2108	31a0b3cb8	JPMS support plan (3-phase approach documented)