Fix/mmaps config overrides and aliases#200
Closed
hermensbas wants to merge 25 commits into
Closed
Conversation
hermensbas
force-pushed
the
fix/mmaps-config-overrides-and-aliases
branch
from
f7ab9be to
a8fac36
Compare
Co-authored-by: blinkysc <blinkysc@users.noreply.github.com>
…azerothcore#25724) Co-authored-by: blinkysc <blinkysc@users.noreply.github.com>
Referenced commit(s): 9083fe2
…25738) Co-authored-by: blinkysc <blinkysc@users.noreply.github.com>
…quest Doing Your Duty. (azerothcore#25746)
Referenced commit(s): 1202a6a
…zerothcore#25679) Co-authored-by: Steffen Schmidt <Steffen.Schmidt@bit-in.de>
Referenced commit(s): 1b152e8
…e#25754) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Referenced commit(s): c36f83b
…hcore#25764) Co-authored-by: blinkysc <blinkysc@users.noreply.github.com> Co-authored-by: ariel- <ariel-@users.noreply.github.com>
…ction (azerothcore#25719) Co-authored-by: blinkysc <blinkysc@users.noreply.github.com> Co-authored-by: Shauren <shauren.trinity@gmail.com>
hermensbas
force-pushed
the
fix/mmaps-config-overrides-and-aliases
branch
6 times, most recently
from
40731b4 to
cf9c6e9
Compare
hermensbas
force-pushed
the
fix/mmaps-config-overrides-and-aliases
branch
from
cf9c6e9 to
1e5d46f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small fixes to the mmaps config parser and shipped YAML so
mmaps-config.yamlactually behaves the way its docs and example claim:vertexPerMapEdge/vertexPerTileEdge) — the parser only reads the singular form (matching every C++ struct, default, and variable name), but the shipped YAML wrote the plural. Plural keys were silently ignored, hidden by C++ defaults that happen to match.vertexPerTileEdgemap override — the struct field and resolver path already existed, but the YAML loader never populated it frommapsOverrides. Wired up.maxSimplificationErrorper-map / per-tile override — promised by the YAML docs and example, but the parser ignored it at both override levels and the resolver hardcoded the global value. Now follows the sameresolveFloatpattern as thewalkable*parameters.Impact
No mmap regeneration needed. Default-config builds produce identical output. Only configs that previously relied on the silently-broken plural keys, or used the documented-but-unimplemented overrides, will see different output — and in those cases the new behaviour matches what was already documented.