playerbot movement systems and fix client_data extraction with updated config#204
Draft
hermensbas wants to merge 1 commit into
Draft
playerbot movement systems and fix client_data extraction with updated config#204hermensbas wants to merge 1 commit into
hermensbas wants to merge 1 commit into
Conversation
hermensbas
changed the title
hermensbas
force-pushed
the
fix/mmaps-config-overrides-and-aliases
branch
2 times, most recently
from
June 5, 2026 08:08
134b183 to
bc96aa5
Compare
hermensbas
force-pushed
the
fix/mmaps-config-overrides-and-aliases
branch
2 times, most recently
from
June 26, 2026 21:10
43fb73a to
4bb6c4d
Compare
mmaps extraction (mmaps-config.yaml + MapBuilder): - Per-map/tile overrides for vertexPerTileEdge and maxSimplificationError; singular vertex*Edge keys. - Tag 50-60deg slopes NAV_GROUND_STEEP (modAlmostUnwalkableTriangles) on top of clearing >60deg. Bot nav filter (PathGenerator, MOD_PLAYERBOTS): - CreateFilter detects a bot via GetSession()->IsBot() and applies a stricter filter: include ground/water, exclude lava/slime and NAV_GROUND_STEEP, and cost deep water. It runs in the constructor so all bot movement is covered; real players and creatures are unchanged. - Add NAV_GROUND_STEEP (0x10) nav flag. - Double MAX_PATH_LENGTH to 148 for long bot routes; expose SetNavTerrainCost/SetExcludeFlags.
hermensbas
force-pushed
the
fix/mmaps-config-overrides-and-aliases
branch
from
June 26, 2026 22:08
4bb6c4d to
65018ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small fixes to the mmaps config parser and shipped YAML so
mmaps-config.yamlactually behaves the way its docs and example claim:vertexPerMapEdge/vertexPerTileEdge) — the parser only reads the singular form (matching every C++ struct, default, and variable name), but the shipped YAML wrote the plural. Plural keys were silently ignored, hidden by C++ defaults that happen to match.vertexPerTileEdgemap override — the struct field and resolver path already existed, but the YAML loader never populated it frommapsOverrides. Wired up.maxSimplificationErrorper-map / per-tile override — promised by the YAML docs and example, but the parser ignored it at both override levels and the resolver hardcoded the global value. Now follows the sameresolveFloatpattern as thewalkable*parameters.Impact
No mmap regeneration needed. Default-config builds produce identical output. Only configs that previously relied on the silently-broken plural keys, or used the documented-but-unimplemented overrides, will see different output — and in those cases the new behaviour matches what was already documented.