modAL.models.BayesianOptimizer .teach(), ._set_max() tests rewritten according to the changes

Author: cosmic-cortex

tests/core_tests.py

@@ -438,7 +438,7 @@ def test_set_max(self):
         # case 1: the estimator is not fitted yet
         regressor = mock.MockClassifier()
         learner = modAL.models.BayesianOptimizer(estimator=regressor)
-        self.assertEqual(None, learner.max_val)
+        self.assertEqual(-np.inf, learner.max_val)
 
         # case 2: the estimator is fitted already
         for n_samples in range(1, 100):
@@ -453,15 +453,15 @@ def test_set_max(self):
             )
             np.testing.assert_almost_equal(max_val, learner.max_val)
 
-    def test_check_max(self):
+    def test_set_new_max(self):
         for n_reps in range(100):
             # case 1: the learner is not fitted yet
             for n_samples in range(1, 10):
                 y = np.random.rand(n_samples)
                 regressor = mock.MockClassifier()
                 learner = modAL.models.BayesianOptimizer(estimator=regressor)
-                learner._check_max(y)
-                self.assertEqual(learner.max_val, None)
+                learner._set_max(y)
+                self.assertEqual(learner.max_val, np.max(y))
 
             # case 2: new value is not a maximum
             for n_samples in range(1, 10):
@@ -476,7 +476,7 @@ def test_check_max(self):
 
                 y_new = y - np.random.rand()
                 old_max = learner.max_val
-                learner._check_max(y_new)
+                learner._set_max(y_new)
                 np.testing.assert_almost_equal(old_max, learner.max_val)
 
             # case 3: new value is a maximum
@@ -491,14 +491,10 @@ def test_check_max(self):
                 )
 
                 y_new = y + np.random.rand()
-                learner._check_max(y_new)
+                learner._set_max(y_new)
                 np.testing.assert_almost_equal(np.max(y_new), learner.max_val)
 
 
-
-
-
-
 class TestCommittee(unittest.TestCase):
 
     def test_set_classes(self):
@@ -649,4 +645,4 @@ def test_examples(self):
 
 
 if __name__ == '__main__':
-    unittest.main()
+    unittest.main(verbosity=2)