Skip to content

Commit fa5806c

Browse files
lemmyCursor Opus 4.8
andcommitted
Add support for Cursor (and other VS Code < 1.120 hosts)
Cursor's bundled VS Code base (e.g. 1.105.1) is older than 1.120, so the extension failed to install with "not compatible with VS Code '1.105.1'". The @types/vscode bump to 1.120.0 had forced engines.vscode up to a floor no Cursor build satisfies, even though the code only uses APIs from 1.53.0. Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de> Co-authored-by: Cursor Opus 4.8 <cursor@cursor.com>
1 parent fb08b81 commit fa5806c

4 files changed

Lines changed: 7 additions & 10 deletions

File tree

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@
131131
"@types/glob": "^9.0.0",
132132
"@types/mocha": "^10.0.10",
133133
"@types/node": "^25.9.1",
134-
"@types/vscode": "^1.120.0",
134+
"@types/vscode": "^1.53.0",
135135
"@typescript-eslint/eslint-plugin": "^8.60.1",
136136
"@typescript-eslint/parser": "^8.60.1",
137137
"@vscode/test-electron": "^2.5.2",

src/test/suite/index.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as path from 'path';
2-
import * as Mocha from 'mocha';
3-
import * as glob from 'glob';
2+
import Mocha from 'mocha';
3+
import { glob } from 'glob';
44

55
export function run(): Promise<void> {
66
// Create the mocha test
@@ -12,11 +12,7 @@ export function run(): Promise<void> {
1212
const testsRoot = path.resolve(__dirname, '..');
1313

1414
return new Promise((c, e) => {
15-
glob('**/**.test.js', { cwd: testsRoot }, (err, files) => {
16-
if (err) {
17-
return e(err);
18-
}
19-
15+
glob('**/**.test.js', { cwd: testsRoot }).then(files => {
2016
// Add files to the test suite
2117
files.forEach(f => mocha.addFile(path.resolve(testsRoot, f)));
2218

@@ -33,6 +29,6 @@ export function run(): Promise<void> {
3329
console.error(err);
3430
e(err);
3531
}
36-
});
32+
}, e);
3733
});
3834
}

tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
"sourceMap": true,
1010
"rootDir": "src",
1111
"newLine": "lf",
12+
"skipLibCheck": true,
1213
"strict": true /* enable all strict type-checking options */
1314
/* Additional Checks */
1415
// "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */

0 commit comments

Comments
 (0)