Skip to content

Add support for Cursor (and other VS Code < 1.120 hosts)#126

Open
lemmy wants to merge 1 commit into
model-checking:mainfrom
lemmy:mku-cursor
Open

Add support for Cursor (and other VS Code < 1.120 hosts)#126
lemmy wants to merge 1 commit into
model-checking:mainfrom
lemmy:mku-cursor

Conversation

@lemmy

@lemmy lemmy commented Jun 7, 2026

Copy link
Copy Markdown

Cursor's bundled VS Code base (e.g. 1.105.1) is older than 1.120, so the extension failed to install with "not compatible with VS Code '1.105.1'". The @types/vscode bump to 1.120.0 had forced engines.vscode up to a floor no Cursor build satisfies, even though the code only uses APIs from 1.53.0.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@feliperodri

feliperodri commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@lemmy could you resolve the conflicts and rebase?

Cursor's bundled VS Code base (e.g. 1.105.1) is older than 1.120, so the
extension failed to install with "not compatible with VS Code '1.105.1'".
The @types/vscode bump to 1.120.0 had forced engines.vscode up to a floor
no Cursor build satisfies, even though the code only uses APIs from 1.53.0.

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
Co-authored-by: Cursor Opus 4.8 <cursor@cursor.com>
@lemmy

lemmy commented Jul 6, 2026

Copy link
Copy Markdown
Author

@feliperodri Done

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to restore install compatibility with Cursor (and other VS Code hosts older than 1.120) by aligning the extension’s TypeScript VS Code typings with the extension’s intended API baseline.

Changes:

  • Downgrade @types/vscode to ^1.53.0 to avoid forcing a higher VS Code compatibility floor.
  • Enable skipLibCheck in tsconfig.json.
  • Update the Mocha test runner harness to use the newer glob Promise API and updated imports.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
tsconfig.json Enables skipLibCheck during TypeScript compilation.
src/test/suite/index.ts Updates Mocha/glob imports and switches globbing to Promise-based usage.
package.json Downgrades @types/vscode to ^1.53.0.
package-lock.json Lockfile update to reflect the @types/vscode version change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/test/suite/index.ts
import * as path from 'path';
import * as Mocha from 'mocha';
import * as glob from 'glob';
import Mocha from 'mocha';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lemmy worth adding?

@lemmy lemmy Jul 7, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This finding is wrong/upside down:

-> % git diff
diff --git a/src/test/suite/index.ts b/src/test/suite/index.ts
index 0ac2b26..534144d 100644
--- a/src/test/suite/index.ts
+++ b/src/test/suite/index.ts
@@ -1,5 +1,5 @@
 import * as path from 'path';
-import Mocha from 'mocha';
+import * as Mocha from 'mocha';
 import { glob } from 'glob';
 
 export function run(): Promise<void> {

-> % npm run compile

> cbmc-proof-debugger@1.0.1 compile
> tsc -p ./

src/test/suite/index.ts:7:20 - error TS2351: This expression is not constructable.
  Type 'typeof Mocha' has no construct signatures.

7  const mocha = new Mocha({
                     ~~~~~

  src/test/suite/index.ts:2:1
    2 import * as Mocha from 'mocha';
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Type originates at this import. A namespace-style import cannot be called or constructed, and will cause a failure at runtime. Consider using a default import or import require here instead.

src/test/suite/index.ts:21:15 - error TS7006: Parameter 'failures' implicitly has an 'any' type.

21     mocha.run(failures => {
                 ~~~~~~~~


Found 2 errors in the same file, starting at: src/test/suite/index.ts:7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants