Add support for Cursor (and other VS Code < 1.120 hosts)#126
Open
lemmy wants to merge 1 commit into
Open
Conversation
feliperodri
approved these changes
Jul 6, 2026
Contributor
|
@lemmy could you resolve the conflicts and rebase? |
Cursor's bundled VS Code base (e.g. 1.105.1) is older than 1.120, so the extension failed to install with "not compatible with VS Code '1.105.1'". The @types/vscode bump to 1.120.0 had forced engines.vscode up to a floor no Cursor build satisfies, even though the code only uses APIs from 1.53.0. Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de> Co-authored-by: Cursor Opus 4.8 <cursor@cursor.com>
Author
|
@feliperodri Done |
There was a problem hiding this comment.
Pull request overview
This PR aims to restore install compatibility with Cursor (and other VS Code hosts older than 1.120) by aligning the extension’s TypeScript VS Code typings with the extension’s intended API baseline.
Changes:
- Downgrade
@types/vscodeto^1.53.0to avoid forcing a higher VS Code compatibility floor. - Enable
skipLibCheckintsconfig.json. - Update the Mocha test runner harness to use the newer
globPromise API and updated imports.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tsconfig.json |
Enables skipLibCheck during TypeScript compilation. |
src/test/suite/index.ts |
Updates Mocha/glob imports and switches globbing to Promise-based usage. |
package.json |
Downgrades @types/vscode to ^1.53.0. |
package-lock.json |
Lockfile update to reflect the @types/vscode version change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import * as path from 'path'; | ||
| import * as Mocha from 'mocha'; | ||
| import * as glob from 'glob'; | ||
| import Mocha from 'mocha'; |
Author
There was a problem hiding this comment.
This finding is wrong/upside down:
-> % git diff
diff --git a/src/test/suite/index.ts b/src/test/suite/index.ts
index 0ac2b26..534144d 100644
--- a/src/test/suite/index.ts
+++ b/src/test/suite/index.ts
@@ -1,5 +1,5 @@
import * as path from 'path';
-import Mocha from 'mocha';
+import * as Mocha from 'mocha';
import { glob } from 'glob';
export function run(): Promise<void> {
-> % npm run compile
> cbmc-proof-debugger@1.0.1 compile
> tsc -p ./
src/test/suite/index.ts:7:20 - error TS2351: This expression is not constructable.
Type 'typeof Mocha' has no construct signatures.
7 const mocha = new Mocha({
~~~~~
src/test/suite/index.ts:2:1
2 import * as Mocha from 'mocha';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Type originates at this import. A namespace-style import cannot be called or constructed, and will cause a failure at runtime. Consider using a default import or import require here instead.
src/test/suite/index.ts:21:15 - error TS7006: Parameter 'failures' implicitly has an 'any' type.
21 mocha.run(failures => {
~~~~~~~~
Found 2 errors in the same file, starting at: src/test/suite/index.ts:7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cursor's bundled VS Code base (e.g. 1.105.1) is older than 1.120, so the extension failed to install with "not compatible with VS Code '1.105.1'". The @types/vscode bump to 1.120.0 had forced engines.vscode up to a floor no Cursor build satisfies, even though the code only uses APIs from 1.53.0.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.