-
Notifications
You must be signed in to change notification settings - Fork 143
Support pointer arithmetic in quantifier predicates #4583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
feliperodri
wants to merge
1
commit into
model-checking:main
Choose a base branch
from
feliperodri:quantifier-pointer-arithmetic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -234,6 +234,15 @@ To solve this, Kani generates **pure expression trees** for quantifier bodies: | |
| are inlined by looking up the function body in the symbol table, resolving its | ||
| return expression, and substituting parameters — producing a pure expression. | ||
|
|
||
| 5. **Pointer arithmetic intrinsic lowering**: Wrapping pointer arithmetic functions | ||
| (`wrapping_byte_offset`, `wrapping_add`) are compiler intrinsics with no GOTO body | ||
|
Comment on lines
+237
to
+238
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about |
||
| to inline. The inliner recognizes these by name and lowers them directly to CBMC | ||
| `Plus` expressions on pointers. Non-wrapping variants (`offset`, `add`) are not | ||
| supported because they trigger CBMC bounds checks inside quantifier bodies. Example: | ||
| ```rust | ||
| kani::forall!(|i in (0, len)| unsafe { *ptr.wrapping_byte_offset(i as isize) == 0 }) | ||
| ``` | ||
|
|
||
| ### Typed quantifier variables | ||
|
|
||
| The `forall!` and `exists!` macros support an optional type annotation: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| // Copyright Kani Contributors | ||
| // SPDX-License-Identifier: Apache-2.0 OR MIT | ||
| // kani-flags: -Z quantifiers | ||
|
|
||
| //! Tests for pointer arithmetic inside quantifier predicates. | ||
| //! These exercise the intrinsic lowering in `inline_call_as_pure_expr` | ||
| //! which converts wrapping_byte_offset/wrapping_add to CBMC Plus. | ||
| //! | ||
| //! Quantifier ranges are half-open: `|i in (lo, hi)|` means `lo <= i < hi`. | ||
| //! All ranges below match the array lengths to stay in-bounds. | ||
|
|
||
| #[kani::proof] | ||
| fn check_wrapping_byte_offset_forall() { | ||
| let arr: [u8; 8] = [0; 8]; | ||
| let ptr = arr.as_ptr(); | ||
| unsafe { | ||
| assert!(kani::forall!(|i in (0, 8)| *ptr.wrapping_byte_offset(i as isize) == 0)); | ||
| } | ||
| } | ||
|
|
||
| #[kani::proof] | ||
| fn check_wrapping_byte_offset_exists() { | ||
| let arr: [u8; 8] = [0, 0, 0, 42, 0, 0, 0, 0]; | ||
| let ptr = arr.as_ptr(); | ||
| unsafe { | ||
| assert!(kani::exists!(|i in (0, 8)| *ptr.wrapping_byte_offset(i as isize) == 42)); | ||
| } | ||
| } | ||
|
|
||
| #[kani::proof] | ||
| fn check_wrapping_add_forall() { | ||
| let arr: [u32; 4] = [10, 20, 30, 40]; | ||
| let ptr = arr.as_ptr(); | ||
| unsafe { | ||
| assert!(kani::forall!(|i in (0, 4)| *ptr.wrapping_add(i) >= 10)); | ||
| } | ||
| } | ||
|
|
||
| /// Tests `ptr.wrapping_add(i)` with a different element type (u8 vs u32). | ||
| #[kani::proof] | ||
| fn check_wrapping_add_u8_forall() { | ||
| let arr: [u8; 4] = [1, 2, 3, 4]; | ||
| let ptr = arr.as_ptr(); | ||
| unsafe { | ||
| assert!(kani::forall!(|i in (0, 4)| *ptr.wrapping_add(i) > 0)); | ||
| } | ||
| } | ||
|
|
||
| #[kani::proof] | ||
| fn check_wrapping_add_exists() { | ||
| let arr: [u32; 4] = [10, 20, 30, 40]; | ||
| let ptr = arr.as_ptr(); | ||
| unsafe { | ||
| assert!(kani::exists!(|i in (0, 4)| *ptr.wrapping_add(i) == 30)); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC the
Plusin CBMC scales by the pointee size, so this is correct forwrapping_add. But is it correct forwrapping_byte_offset? Maybe the pointer and offset have already been lowered to bytes?