make_ascii_uppercase/lowercase harnesses#368
Closed
AlexLB99 wants to merge 6 commits intomodel-checking:mainfrom
Closed
make_ascii_uppercase/lowercase harnesses#368AlexLB99 wants to merge 6 commits intomodel-checking:mainfrom
AlexLB99 wants to merge 6 commits intomodel-checking:mainfrom
Conversation
tautschnig
reviewed
May 30, 2025
Comment on lines
+3089
to
+3096
|
|
||
| for (i, &item) in s.as_bytes().iter().enumerate() { | ||
| if item >= b'a' && item <= b'z' { | ||
| assert_eq!(s_uppercase[i], item - 32); | ||
| } else { | ||
| assert_eq!(s_uppercase[i], item); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Couldn't this be expressed as a post-condition (ensures) on make_ascii_uppercase?
There was a problem hiding this comment.
@AlexLB99 Kani supports Quantifiers now: https://model-checking.github.io/kani/reference/experimental/quantifiers.html. I strongly suggest trying this feature for the case.
|
@AlexLB99 should we close this PR? |
Author
Thanks for letting me know -- I'll probably revisit this in the future, but we could close it for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards solving #19
These are harnesses for functions make_ascii_uppercase() and make_ascii_lowercase(). They check that only the correct letters are modified (and that those that do need to be modified become the correct uppercase/lowercase character).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.