Skip to content

Commit 12c5f7d

Browse files
pcarletonclaude
andcommitted
[auth] Rename basic-dcr scenarios to metadata variants
Consolidate auth metadata discovery scenarios with consistent naming: - AuthBasicDCRScenario → AuthMetadataDefaultScenario (auth/metadata-default) - AuthBasicMetadataVar1Scenario → AuthMetadataVar1Scenario (auth/metadata-var1) - AuthBasicMetadataVar2Scenario → AuthMetadataVar2Scenario (auth/metadata-var2) - AuthBasicMetadataVar3Scenario → AuthMetadataVar3Scenario (auth/metadata-var3) Also updates descriptions to use consistent markdown formatting with bold headers for Registration, PRM, and OAuth metadata fields. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent de7060c commit 12c5f7d

3 files changed

Lines changed: 40 additions & 28 deletions

File tree

src/scenarios/client/auth/discovery-metadata.ts

Lines changed: 31 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,14 @@ import { ServerLifecycle } from './helpers/serverLifecycle.js';
66
import { SpecReferences } from './spec-references.js';
77
import { Request, Response } from 'express';
88

9-
export class AuthBasicDCRScenario implements Scenario {
10-
name = 'auth/basic-dcr';
11-
description =
12-
'Tests Basic OAuth flow with DCR, PRM at path-based location, OAuth metadata at root location, and no scopes required';
9+
export class AuthMetadataDefaultScenario implements Scenario {
10+
name = 'auth/metadata-default';
11+
description = `Tests Basic OAuth metadata discovery flow.
12+
13+
**Registration:** via DCR
14+
**PRM:** at path-based location (root returns 404)
15+
**OAuth metadata:** at root oauth-authorization-server path
16+
`;
1317
private authServer = new ServerLifecycle();
1418
private server = new ServerLifecycle();
1519
private checks: ConformanceCheck[] = [];
@@ -92,13 +96,13 @@ export class AuthBasicDCRScenario implements Scenario {
9296
}
9397
}
9498

95-
export class AuthBasicMetadataVar1Scenario implements Scenario {
96-
name = 'auth/basic-metadata-var1';
97-
description = `
98-
Tests Basic OAuth flow with:
99-
Registration: via DCR
100-
PRM: At the path-based location (not in WWW-authenticate)
101-
OAuth metadata: at OpenID discovery path
99+
export class AuthMetadataVar1Scenario implements Scenario {
100+
name = 'auth/metadata-var1';
101+
description = `Tests Basic OAuth metadata discovery flow.
102+
103+
**Registration:** via DCR
104+
**PRM:** at root location (not in WWW-Authenticate)
105+
**OAuth metadata:** at root openid-configuration path
102106
`;
103107
private authServer = new ServerLifecycle();
104108
private server = new ServerLifecycle();
@@ -156,10 +160,14 @@ OAuth metadata: at OpenID discovery path
156160
}
157161
}
158162

159-
export class AuthBasicMetadataVar2Scenario implements Scenario {
160-
name = 'auth/basic-metadata-var2';
161-
description =
162-
'Tests Basic OAuth flow with DCR, PRM at root location, OAuth metadata at path-based OAuth discovery path';
163+
export class AuthMetadataVar2Scenario implements Scenario {
164+
name = 'auth/metadata-var2';
165+
description = `Tests Basic OAuth metadata discovery flow.
166+
167+
**Registration:** via DCR
168+
**PRM:** at root location
169+
**OAuth metadata:** at path-based openid-configuration path (/tenant1)
170+
`;
163171
private authServer = new ServerLifecycle();
164172
private server = new ServerLifecycle();
165173
private checks: ConformanceCheck[] = [];
@@ -236,10 +244,14 @@ export class AuthBasicMetadataVar2Scenario implements Scenario {
236244
}
237245
}
238246

239-
export class AuthBasicMetadataVar3Scenario implements Scenario {
240-
name = 'auth/basic-metadata-var3';
241-
description =
242-
'Tests Basic OAuth flow with DCR, PRM at custom location listed in WWW-Authenticate header, OAuth metadata is at nested OpenID discovery path, and no scopes required';
247+
export class AuthMetadataVar3Scenario implements Scenario {
248+
name = 'auth/metadata-var3';
249+
description = `Tests Basic OAuth metadata discovery flow.
250+
251+
**Registration:** via DCR
252+
**PRM:** at custom path (via resource_metadata in WWW-Authenticate)
253+
**OAuth metadata:** at path-based openid-configuration path (/tenant1)
254+
`;
243255
private authServer = new ServerLifecycle();
244256
private server = new ServerLifecycle();
245257
private checks: ConformanceCheck[] = [];

src/scenarios/client/auth/index.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ describe('Client Auth Scenarios', () => {
4242
describe('Negative tests', () => {
4343
test('bad client requests root PRM location', async () => {
4444
const runner = new InlineClientRunner(badPrmClient);
45-
await runClientAgainstScenario(runner, 'auth/basic-dcr', [
45+
await runClientAgainstScenario(runner, 'auth/metadata-default', [
4646
'prm-priority-order'
4747
]);
4848
});

src/scenarios/client/auth/index.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { Scenario } from '../../../types';
2-
import { AuthBasicDCRScenario } from './basic-dcr.js';
32
import {
4-
AuthBasicMetadataVar1Scenario,
5-
AuthBasicMetadataVar2Scenario,
6-
AuthBasicMetadataVar3Scenario
3+
AuthMetadataDefaultScenario,
4+
AuthMetadataVar1Scenario,
5+
AuthMetadataVar2Scenario,
6+
AuthMetadataVar3Scenario
77
} from './discovery-metadata.js';
88
import {
99
Auth20250326OAuthMetadataBackcompatScenario,
@@ -17,10 +17,10 @@ import {
1717
} from './scope-handling.js';
1818

1919
export const authScenariosList: Scenario[] = [
20-
new AuthBasicDCRScenario(),
21-
new AuthBasicMetadataVar1Scenario(),
22-
new AuthBasicMetadataVar2Scenario(),
23-
new AuthBasicMetadataVar3Scenario(),
20+
new AuthMetadataDefaultScenario(),
21+
new AuthMetadataVar1Scenario(),
22+
new AuthMetadataVar2Scenario(),
23+
new AuthMetadataVar3Scenario(),
2424
new Auth20250326OAuthMetadataBackcompatScenario(),
2525
new Auth20250326OEndpointFallbackScenario(),
2626
new ScopeFromWwwAuthenticateScenario(),

0 commit comments

Comments
 (0)