Skip to content

Commit 211a140

Browse files
committed
Address PR feedback
1 parent 4ee0f98 commit 211a140

File tree

3 files changed

+8
-14
lines changed

3 files changed

+8
-14
lines changed

src/ModelContextProtocol.Core/McpSessionHandler.cs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -317,16 +317,14 @@ private async Task HandleMessageAsync(JsonRpcMessage message, CancellationToken
317317
AddTags(ref tags, activity, message, method, target);
318318
}
319319

320-
var filteredHandler = _incomingMessageFilter(async (msg, ct) =>
320+
await _incomingMessageFilter(async (msg, ct) =>
321321
{
322322
var result = await HandleMessageCoreAsync(msg, ct).ConfigureAwait(false);
323323
if (addTags && result is not null)
324324
{
325325
AddResponseTags(ref tags, activity, result, method);
326326
}
327-
});
328-
329-
await filteredHandler(message, cancellationToken).ConfigureAwait(false);
327+
})(message, cancellationToken).ConfigureAwait(false);
330328
}
331329
catch (Exception e) when (addTags)
332330
{
@@ -607,7 +605,7 @@ public async Task SendMessageAsync(JsonRpcMessage message, CancellationToken can
607605
AddTags(ref tags, activity, message, method, target);
608606
}
609607

610-
var filteredHandler = _outgoingMessageFilter(async (msg, ct) =>
608+
await _outgoingMessageFilter(async (msg, ct) =>
611609
{
612610
if (_logger.IsEnabled(LogLevel.Trace))
613611
{
@@ -629,9 +627,7 @@ public async Task SendMessageAsync(JsonRpcMessage message, CancellationToken can
629627
{
630628
tcs.TrySetCanceled(default);
631629
}
632-
});
633-
634-
await filteredHandler(message, cancellationToken).ConfigureAwait(false);
630+
})(message, cancellationToken).ConfigureAwait(false);
635631
}
636632
catch (Exception ex) when (addTags)
637633
{

src/ModelContextProtocol.Core/Server/MessageContext.cs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ namespace ModelContextProtocol.Server;
1919
/// </remarks>
2020
public class MessageContext
2121
{
22-
/// <summary>The server with which this instance is associated.</summary>
23-
private McpServer _server;
24-
2522
/// <summary>
2623
/// Initializes a new instance of the <see cref="MessageContext"/> class with the specified server and JSON-RPC message.
2724
/// </summary>
@@ -32,7 +29,7 @@ public MessageContext(McpServer server, JsonRpcMessage jsonRpcMessage)
3229
Throw.IfNull(server);
3330
Throw.IfNull(jsonRpcMessage);
3431

35-
_server = server;
32+
Server = server;
3633
JsonRpcMessage = jsonRpcMessage;
3734
Services = server.Services;
3835
User = jsonRpcMessage.Context?.User;
@@ -41,11 +38,11 @@ public MessageContext(McpServer server, JsonRpcMessage jsonRpcMessage)
4138
/// <summary>Gets or sets the server with which this instance is associated.</summary>
4239
public McpServer Server
4340
{
44-
get => _server;
41+
get => field;
4542
set
4643
{
4744
Throw.IfNull(value);
48-
_server = value;
45+
field = value;
4946
}
5047
}
5148

src/ModelContextProtocol/McpServerBuilderExtensions.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1137,6 +1137,7 @@ public static IMcpServerBuilder AddSetLoggingLevelFilter(this IMcpServerBuilder
11371137
public static IMcpServerBuilder AddIncomingMessageFilter(this IMcpServerBuilder builder, McpMessageFilter filter)
11381138
{
11391139
Throw.IfNull(builder);
1140+
Throw.IfNull(filter);
11401141

11411142
builder.Services.Configure<McpServerOptions>(options => options.Filters.IncomingMessageFilters.Add(filter));
11421143
return builder;

0 commit comments

Comments
 (0)