PollingInterval -> StreamReaderPollingInterval

Author: MackinnonBuck

src/ModelContextProtocol/Server/DistributedCacheEventStreamStore.cs

@@ -351,8 +351,8 @@ public DistributedCacheEventStreamReader(
                 }
 
                 // Wait before polling again for new events
-                LogWaitingForNewEvents(SessionId, StreamId, _options.PollingInterval);
-                await Task.Delay(_options.PollingInterval, cancellationToken).ConfigureAwait(false);
+                LogWaitingForNewEvents(SessionId, StreamId, _options.StreamReaderPollingInterval);
+                await Task.Delay(_options.StreamReaderPollingInterval, cancellationToken).ConfigureAwait(false);
 
                 // Refresh metadata to get the latest sequence and completion status
                 var metadataKey = CacheKeys.StreamMetadata(SessionId, StreamId);

src/ModelContextProtocol/Server/DistributedCacheEventStreamStoreOptions.cs

@@ -40,12 +40,12 @@ public sealed class DistributedCacheEventStreamStoreOptions
     public TimeSpan? MetadataAbsoluteExpiration { get; set; } = TimeSpan.FromHours(4);
 
     /// <summary>
-    /// Gets or sets the interval between polling attempts when a reader is waiting for new events
+    /// Gets or sets the interval between polling attempts when a stream reader is waiting for new events
     /// in the default <see cref="SseEventStreamMode.Streaming"/> mode.
     /// </summary>
     /// <remarks>
-    /// This only affects readers. A shorter interval provides lower latency for new events
+    /// This only affects stream readers. A shorter interval provides lower latency for new events
     /// but increases cache access frequency.
     /// </remarks>
-    public TimeSpan PollingInterval { get; set; } = TimeSpan.FromMilliseconds(100);
+    public TimeSpan StreamReaderPollingInterval { get; set; } = TimeSpan.FromSeconds(1);
 }

tests/ModelContextProtocol.AspNetCore.Tests/DistributedCacheResumabilityIntegrationTests.cs

@@ -34,7 +34,7 @@ protected override ValueTask<ISseEventStreamStore> CreateEventStreamStoreAsync()
         var options = new DistributedCacheEventStreamStoreOptions
         {
             // Use shorter polling interval for faster test execution
-            PollingInterval = TimeSpan.FromMilliseconds(50),
+            StreamReaderPollingInterval = TimeSpan.FromMilliseconds(50),
 
             // Use shorter expiration times for tests
             EventSlidingExpiration = TimeSpan.FromMinutes(5),

tests/ModelContextProtocol.Tests/Server/DistributedCacheEventStreamStoreTests.cs

@@ -352,7 +352,7 @@ public async Task SetModeAsync_ModeChangeReflectedInReader()
         var cache = CreateMemoryCache();
         var customOptions = new DistributedCacheEventStreamStoreOptions
         {
-            PollingInterval = TimeSpan.FromMilliseconds(10)
+            StreamReaderPollingInterval = TimeSpan.FromMilliseconds(10)
         };
         var store = new DistributedCacheEventStreamStore(cache, customOptions);
         var writer = await store.CreateStreamAsync(new SseEventStreamOptions
@@ -814,7 +814,7 @@ public async Task ReadEventsAsync_InStreamingMode_WaitsForNewEvents()
         var cache = CreateMemoryCache();
         var store = new DistributedCacheEventStreamStore(cache, new DistributedCacheEventStreamStoreOptions
         {
-            PollingInterval = TimeSpan.FromMilliseconds(50)
+            StreamReaderPollingInterval = TimeSpan.FromMilliseconds(50)
         });
         var writer = await store.CreateStreamAsync(new SseEventStreamOptions
         {
@@ -871,7 +871,7 @@ public async Task ReadEventsAsync_InStreamingMode_YieldsNewlyWrittenEvents()
         var cache = CreateMemoryCache();
         var store = new DistributedCacheEventStreamStore(cache, new DistributedCacheEventStreamStoreOptions
         {
-            PollingInterval = TimeSpan.FromMilliseconds(50)
+            StreamReaderPollingInterval = TimeSpan.FromMilliseconds(50)
         });
         var writer = await store.CreateStreamAsync(new SseEventStreamOptions
         {
@@ -929,7 +929,7 @@ public async Task ReadEventsAsync_InStreamingMode_CompletesWhenStreamIsDisposed(
         var cache = CreateMemoryCache();
         var store = new DistributedCacheEventStreamStore(cache, new DistributedCacheEventStreamStoreOptions
         {
-            PollingInterval = TimeSpan.FromMilliseconds(50)
+            StreamReaderPollingInterval = TimeSpan.FromMilliseconds(50)
         });
         var writer = await store.CreateStreamAsync(new SseEventStreamOptions
         {
@@ -967,7 +967,7 @@ public async Task ReadEventsAsync_InStreamingMode_RespectsCancellation()
         var cache = CreateMemoryCache();
         var store = new DistributedCacheEventStreamStore(cache, new DistributedCacheEventStreamStoreOptions
         {
-            PollingInterval = TimeSpan.FromMilliseconds(50)
+            StreamReaderPollingInterval = TimeSpan.FromMilliseconds(50)
         });
         var writer = await store.CreateStreamAsync(new SseEventStreamOptions
         {
@@ -1031,7 +1031,7 @@ public async Task ReadEventsAsync_RespectsModeSwitchFromStreamingToPolling()
         var cache = CreateMemoryCache();
         var store = new DistributedCacheEventStreamStore(cache, new DistributedCacheEventStreamStoreOptions
         {
-            PollingInterval = TimeSpan.FromMilliseconds(50)
+            StreamReaderPollingInterval = TimeSpan.FromMilliseconds(50)
         });
         var writer = await store.CreateStreamAsync(new SseEventStreamOptions
         {
@@ -1076,7 +1076,7 @@ public async Task ReadEventsAsync_PollingModeReturnsEventsThenCompletes()
         var cache = CreateMemoryCache();
         var store = new DistributedCacheEventStreamStore(cache, new DistributedCacheEventStreamStoreOptions
         {
-            PollingInterval = TimeSpan.FromMilliseconds(50)
+            StreamReaderPollingInterval = TimeSpan.FromMilliseconds(50)
         });
         var writer = await store.CreateStreamAsync(new SseEventStreamOptions
         {
@@ -1350,7 +1350,7 @@ public void DefaultOptions_HaveReasonableDefaults()
         var options = new DistributedCacheEventStreamStoreOptions();
 
         // Assert - Check that defaults are set reasonably
-        Assert.True(options.PollingInterval >= TimeSpan.FromMilliseconds(50), "Polling interval should be at least 50ms");
+        Assert.True(options.StreamReaderPollingInterval >= TimeSpan.FromMilliseconds(50), "Polling interval should be at least 50ms");
         Assert.True(options.EventSlidingExpiration > TimeSpan.Zero, "Event sliding expiration should be positive");
         Assert.True(options.EventAbsoluteExpiration > TimeSpan.Zero, "Event absolute expiration should be positive");
         Assert.True(options.MetadataSlidingExpiration > TimeSpan.Zero, "Metadata sliding expiration should be positive");
@@ -1364,7 +1364,7 @@ public async Task ReadEventsAsync_ThrowsMcpException_WhenMetadataExpires()
         var trackingCache = new TestDistributedCache();
         var customOptions = new DistributedCacheEventStreamStoreOptions
         {
-            PollingInterval = TimeSpan.FromMilliseconds(10) // Fast polling to detect the bug quickly
+            StreamReaderPollingInterval = TimeSpan.FromMilliseconds(10) // Fast polling to detect the bug quickly
         };
         var store = new DistributedCacheEventStreamStore(trackingCache, customOptions);
 
@@ -1448,7 +1448,7 @@ public async Task ReadEventsAsync_DoesNotReadMetadata_InPollingMode()
         var trackingCache = new TestDistributedCache();
         var customOptions = new DistributedCacheEventStreamStoreOptions
         {
-            PollingInterval = TimeSpan.FromMilliseconds(10)
+            StreamReaderPollingInterval = TimeSpan.FromMilliseconds(10)
         };
         var store = new DistributedCacheEventStreamStore(trackingCache, customOptions);