Skip to content

Commit 4648d3e

Browse files
Copilotstephentoub
andauthored
Make UrlElicitationRequiredErrorData.Elicitations consistent with other Protocol DTOs (#1335)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
1 parent 451da4d commit 4648d3e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/ModelContextProtocol.Core/Protocol/UrlElicitationRequiredErrorData.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ public sealed class UrlElicitationRequiredErrorData
1212
/// Gets or sets the elicitations that must be completed before retrying the original request.
1313
/// </summary>
1414
[JsonPropertyName("elicitations")]
15-
public required IReadOnlyList<ElicitRequestParams> Elicitations { get; init; }
15+
public required IList<ElicitRequestParams> Elicitations { get; set; }
1616
}

src/ModelContextProtocol.Core/UrlElicitationRequiredException.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ namespace ModelContextProtocol;
1212
/// </summary>
1313
public sealed class UrlElicitationRequiredException : McpProtocolException
1414
{
15-
private readonly IReadOnlyList<ElicitRequestParams> _elicitations;
15+
private readonly List<ElicitRequestParams> _elicitations;
1616

1717
/// <summary>
1818
/// Initializes a new instance of the <see cref="UrlElicitationRequiredException"/> class with the specified message and pending elicitations.
@@ -66,7 +66,7 @@ internal static bool TryCreateFromError(
6666
return true;
6767
}
6868

69-
private static bool TryParseElicitations(JsonElement dataElement, out IReadOnlyList<ElicitRequestParams> elicitations)
69+
private static bool TryParseElicitations(JsonElement dataElement, out IList<ElicitRequestParams> elicitations)
7070
{
7171
elicitations = [];
7272

@@ -93,7 +93,7 @@ private static bool TryParseElicitations(JsonElement dataElement, out IReadOnlyL
9393
return true;
9494
}
9595

96-
private static IReadOnlyList<ElicitRequestParams> Validate(IEnumerable<ElicitRequestParams> elicitations)
96+
private static List<ElicitRequestParams> Validate(IEnumerable<ElicitRequestParams> elicitations)
9797
{
9898
var list = new List<ElicitRequestParams>();
9999
foreach (var elicitation in elicitations)

0 commit comments

Comments
 (0)