Commit 58512d8
Address review feedback on cacheScope converter and conformance gate
- CacheScopeConverter.Read now consumes non-string tokens with reader.Skip()
before returning null. Previously an object or array value for cacheScope
left the reader mispositioned and threw "read too much or not enough",
breaking deserialization of the whole result. Added object and array cases
to the tolerant-deserialization test.
- GetInstalledConformanceVersion no longer calls EnsureNpmDependenciesInstalled.
The version check backs Theory skip gates and must be side-effect-free; it
now returns null when the conformance package is absent. The actual scenario
run path still restores npm dependencies via ConformanceTestStartInfo.1 parent 51571c6 commit 58512d8
3 files changed
Lines changed: 13 additions & 9 deletions
File tree
- src/ModelContextProtocol.Core/Protocol
- tests
- Common/Utils
- ModelContextProtocol.Tests/Protocol
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
43 | 45 | | |
44 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
45 | 52 | | |
46 | 53 | | |
47 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
224 | 224 | | |
225 | 225 | | |
226 | 226 | | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
235 | 231 | | |
236 | 232 | | |
237 | 233 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
175 | | - | |
| 175 | + | |
| 176 | + | |
176 | 177 | | |
177 | 178 | | |
178 | 179 | | |
| |||
0 commit comments