Skip to content

Commit 669781d

Browse files
Copilotstephentoub
andcommitted
Add IsEnabled guards for received message logging
Guard LogTransportReceivedMessageSensitive calls with IsEnabled(LogLevel.Trace) checks to avoid unnecessary work when trace logging is disabled. Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
1 parent 9d9d8af commit 669781d

4 files changed

Lines changed: 16 additions & 4 deletions

File tree

src/ModelContextProtocol.Core/Client/SseClientSessionTransport.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,10 @@ private async Task ProcessSseMessage(string data, CancellationToken cancellation
198198
return;
199199
}
200200

201-
LogTransportReceivedMessageSensitive(Name, data);
201+
if (_logger.IsEnabled(LogLevel.Trace))
202+
{
203+
LogTransportReceivedMessageSensitive(Name, data);
204+
}
202205

203206
try
204207
{

src/ModelContextProtocol.Core/Client/StreamClientSessionTransport.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,10 @@ private async Task ReadMessagesAsync(CancellationToken cancellationToken)
148148
continue;
149149
}
150150

151-
LogTransportReceivedMessageSensitive(Name, line);
151+
if (Logger.IsEnabled(LogLevel.Trace))
152+
{
153+
LogTransportReceivedMessageSensitive(Name, line);
154+
}
152155

153156
await ProcessMessageAsync(line, cancellationToken).ConfigureAwait(false);
154157
}

src/ModelContextProtocol.Core/Client/StreamableHttpClientSessionTransport.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,10 @@ private async Task<SseResponse> ProcessSseResponseAsync(
347347

348348
private async Task<JsonRpcMessageWithId?> ProcessMessageAsync(string data, JsonRpcRequest? relatedRpcRequest, CancellationToken cancellationToken)
349349
{
350-
LogTransportReceivedMessageSensitive(Name, data);
350+
if (_logger.IsEnabled(LogLevel.Trace))
351+
{
352+
LogTransportReceivedMessageSensitive(Name, data);
353+
}
351354

352355
try
353356
{

src/ModelContextProtocol.Core/Server/StreamServerTransport.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,10 @@ private async Task ReadMessagesAsync()
112112
continue;
113113
}
114114

115-
LogTransportReceivedMessageSensitive(Name, line);
115+
if (Logger.IsEnabled(LogLevel.Trace))
116+
{
117+
LogTransportReceivedMessageSensitive(Name, line);
118+
}
116119

117120
try
118121
{

0 commit comments

Comments
 (0)