Skip to content

Commit 6a46049

Browse files
Copilotstephentoub
andcommitted
Address review feedback: use StartsWith for text MIME check, improve binary resource comment, restore Count <= 100 assertion
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
1 parent ca82e6a commit 6a46049

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

tests/ModelContextProtocol.Tests/ClientIntegrationTests.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ public async Task ReadResource_Stdio_TextResource(string clientId)
233233
await using var client = await _fixture.CreateClientAsync(clientId);
234234
// Get available resources and read one that is text
235235
var resources = await client.ListResourcesAsync(cancellationToken: TestContext.Current.CancellationToken);
236-
var textResource = resources.First(r => r.MimeType is "text/plain" or "text/markdown");
236+
var textResource = resources.First(r => r.MimeType?.StartsWith("text/", StringComparison.Ordinal) is true);
237237
var result = await client.ReadResourceAsync(textResource.Uri, null, TestContext.Current.CancellationToken);
238238

239239
Assert.NotNull(result);
@@ -243,7 +243,8 @@ public async Task ReadResource_Stdio_TextResource(string clientId)
243243
Assert.NotNull(textContent.Text);
244244
}
245245

246-
// Not supported by "everything" server version on npx
246+
// The latest "everything" server only exposes text-based file resources in its resource list;
247+
// binary resources are available via resource templates but not in the listed resources.
247248
[Fact]
248249
public async Task ReadResource_Stdio_BinaryResource()
249250
{
@@ -649,8 +650,9 @@ public async Task ListResourcesAsync_WithRequestParams_ReturnsRawResult(string c
649650
TestContext.Current.CancellationToken);
650651

651652
Assert.NotNull(result);
652-
// Low-level API returns only one page
653+
// Low-level API returns only one page; the server provides resources but paginates
653654
Assert.NotEmpty(result.Resources);
655+
Assert.True(result.Resources.Count <= 100);
654656
}
655657

656658
[Theory]

0 commit comments

Comments
 (0)