Skip to content

Commit a7b20dc

Browse files
author
Tarek Mahmoud Sayed
committed
Remove stale ApiCompat suppressions for re-added TimeSpanMillisecondsConverter
The upstream merge brought in CP0001 baseline suppressions for TimeSpanMillisecondsConverter (the Tasks rework had deleted the type). This branch keeps the type for the SEP-2549 cacheable results, so those suppressions are now unnecessary and fail package validation (make pack) in Release. Drop the four stale entries so ApiCompat passes.
1 parent 22e7fbc commit a7b20dc

1 file changed

Lines changed: 0 additions & 28 deletions

File tree

src/ModelContextProtocol.Core/CompatibilitySuppressions.xml

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -134,13 +134,6 @@
134134
<Right>lib/net10.0/ModelContextProtocol.Core.dll</Right>
135135
<IsBaselineSuppression>true</IsBaselineSuppression>
136136
</Suppression>
137-
<Suppression>
138-
<DiagnosticId>CP0001</DiagnosticId>
139-
<Target>T:ModelContextProtocol.Protocol.TimeSpanMillisecondsConverter</Target>
140-
<Left>lib/net10.0/ModelContextProtocol.Core.dll</Left>
141-
<Right>lib/net10.0/ModelContextProtocol.Core.dll</Right>
142-
<IsBaselineSuppression>true</IsBaselineSuppression>
143-
</Suppression>
144137
<Suppression>
145138
<DiagnosticId>CP0001</DiagnosticId>
146139
<Target>T:ModelContextProtocol.Protocol.ToolExecution</Target>
@@ -295,13 +288,6 @@
295288
<Right>lib/net8.0/ModelContextProtocol.Core.dll</Right>
296289
<IsBaselineSuppression>true</IsBaselineSuppression>
297290
</Suppression>
298-
<Suppression>
299-
<DiagnosticId>CP0001</DiagnosticId>
300-
<Target>T:ModelContextProtocol.Protocol.TimeSpanMillisecondsConverter</Target>
301-
<Left>lib/net8.0/ModelContextProtocol.Core.dll</Left>
302-
<Right>lib/net8.0/ModelContextProtocol.Core.dll</Right>
303-
<IsBaselineSuppression>true</IsBaselineSuppression>
304-
</Suppression>
305291
<Suppression>
306292
<DiagnosticId>CP0001</DiagnosticId>
307293
<Target>T:ModelContextProtocol.Protocol.ToolExecution</Target>
@@ -456,13 +442,6 @@
456442
<Right>lib/net9.0/ModelContextProtocol.Core.dll</Right>
457443
<IsBaselineSuppression>true</IsBaselineSuppression>
458444
</Suppression>
459-
<Suppression>
460-
<DiagnosticId>CP0001</DiagnosticId>
461-
<Target>T:ModelContextProtocol.Protocol.TimeSpanMillisecondsConverter</Target>
462-
<Left>lib/net9.0/ModelContextProtocol.Core.dll</Left>
463-
<Right>lib/net9.0/ModelContextProtocol.Core.dll</Right>
464-
<IsBaselineSuppression>true</IsBaselineSuppression>
465-
</Suppression>
466445
<Suppression>
467446
<DiagnosticId>CP0001</DiagnosticId>
468447
<Target>T:ModelContextProtocol.Protocol.ToolExecution</Target>
@@ -617,13 +596,6 @@
617596
<Right>lib/netstandard2.0/ModelContextProtocol.Core.dll</Right>
618597
<IsBaselineSuppression>true</IsBaselineSuppression>
619598
</Suppression>
620-
<Suppression>
621-
<DiagnosticId>CP0001</DiagnosticId>
622-
<Target>T:ModelContextProtocol.Protocol.TimeSpanMillisecondsConverter</Target>
623-
<Left>lib/netstandard2.0/ModelContextProtocol.Core.dll</Left>
624-
<Right>lib/netstandard2.0/ModelContextProtocol.Core.dll</Right>
625-
<IsBaselineSuppression>true</IsBaselineSuppression>
626-
</Suppression>
627599
<Suppression>
628600
<DiagnosticId>CP0001</DiagnosticId>
629601
<Target>T:ModelContextProtocol.Protocol.ToolExecution</Target>

0 commit comments

Comments
 (0)