Fix flaky Should_Start_In_Connected_State test

halter73 · halter73 · commit cba8523b2d35 · 2025-03-30T14:11:56.000-07:00
diff --git a/src/ModelContextProtocol/Shared/McpJsonRpcEndpoint.cs b/src/ModelContextProtocol/Shared/McpJsonRpcEndpoint.cs
@@ -101,7 +101,6 @@ public async ValueTask DisposeAsync()
     /// <returns></returns>
     public virtual async ValueTask DisposeUnsynchronizedAsync()
     {
-        // Both McpClient and McpServer guard this with a semaphore
         _logger.CleaningUpEndpoint(EndpointName);
 
         if (_sessionCts is not null)
diff --git a/tests/ModelContextProtocol.Tests/Transport/StdioServerTransportTests.cs b/tests/ModelContextProtocol.Tests/Transport/StdioServerTransportTests.cs
@@ -58,7 +58,7 @@ public void Constructor_Throws_For_Null_Options()
     [Fact]
     public async Task Should_Start_In_Connected_State()
     {
-        await using var transport = new StdioServerTransport(_serverOptions.ServerInfo.Name, Stream.Null, Stream.Null, LoggerFactory);
+        await using var transport = new StdioServerTransport(_serverOptions.ServerInfo.Name, new Pipe().Reader.AsStream(), Stream.Null, LoggerFactory);
 
         Assert.True(transport.IsConnected);
     }

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,6 @@ public async ValueTask DisposeAsync()`
`101`	`101`	`/// <returns></returns>`
`102`	`102`	`public virtual async ValueTask DisposeUnsynchronizedAsync()`
`103`	`103`	`{`
`104`		`- // Both McpClient and McpServer guard this with a semaphore`
`105`	`104`	`_logger.CleaningUpEndpoint(EndpointName);`
`106`	`105`
`107`	`106`	`if (_sessionCts is not null)`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public void Constructor_Throws_For_Null_Options()`
`58`	`58`	`[Fact]`
`59`	`59`	`public async Task Should_Start_In_Connected_State()`
`60`	`60`	`{`
`61`		`- await using var transport = new StdioServerTransport(_serverOptions.ServerInfo.Name, Stream.Null, Stream.Null, LoggerFactory);`
	`61`	`+ await using var transport = new StdioServerTransport(_serverOptions.ServerInfo.Name, new Pipe().Reader.AsStream(), Stream.Null, LoggerFactory);`
`62`	`62`
`63`	`63`	`Assert.True(transport.IsConnected);`
`64`	`64`	`}`