Skip to content

Commit ce471c2

Browse files
authored
Apply suggestion from @ericstj
1 parent b6efae1 commit ce471c2

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

tests/ModelContextProtocol.AspNetCore.Tests/MapMcpTests.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -443,8 +443,11 @@ public async Task OutgoingFilter_MultipleFilters_ExecuteInOrder()
443443

444444
// The outermost filter's "after" callback runs after the response has been
445445
// sent to the client, so ListToolsAsync may return before it executes.
446-
// Wait for it to complete before asserting.
447-
await allFiltersComplete.Task.WaitAsync(TestContext.Current.CancellationToken);
446+
// Wait for it to complete before asserting, but use a timeout to avoid hanging
447+
// the test indefinitely if the filter pipeline regresses.
448+
using var allFiltersCts = CancellationTokenSource.CreateLinkedTokenSource(TestContext.Current.CancellationToken);
449+
allFiltersCts.CancelAfter(TestConstants.DefaultTimeout);
450+
await allFiltersComplete.Task.WaitAsync(allFiltersCts.Token);
448451

449452
Assert.Equal(["filter1-before", "filter2-before", "filter2-after", "filter1-after"], executionOrder);
450453
}

0 commit comments

Comments
 (0)