add comment on session duration

Liudmila Molkova · stephentoub · commit cf45d2d9edc4 · 2025-04-12T22:00:50.000-04:00
diff --git a/src/ModelContextProtocol/Shared/McpSession.cs b/src/ModelContextProtocol/Shared/McpSession.cs
@@ -645,6 +645,9 @@ public void Dispose()
         {
             TagList tags = default;
             tags.Add("network.transport", _transportKind);
+
+            // TODO (lmolkova): add server.address and server.port on client-side when using SSE transport,
+            // client.* attributes are not added to metrics because of cardinality
             durationMetric.Record(GetElapsed(_sessionStartingTimestamp).TotalSeconds, tags);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -645,6 +645,9 @@ public void Dispose()`
`645`	`645`	`{`
`646`	`646`	`TagList tags = default;`
`647`	`647`	`tags.Add("network.transport", _transportKind);`
	`648`	`+`
	`649`	`+ // TODO (lmolkova): add server.address and server.port on client-side when using SSE transport,`
	`650`	`+ // client.* attributes are not added to metrics because of cardinality`
`648`	`651`	`durationMetric.Record(GetElapsed(_sessionStartingTimestamp).TotalSeconds, tags);`
`649`	`652`	`}`
`650`	`653`